SharedArrayBuffers can cause crashes when inspected in certain ways

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:

Other

1.92k stars 340 forks source link

SharedArrayBuffers can cause crashes when inspected in certain ways #584

Open MSLaguana opened 6 years ago

MSLaguana commented 6 years ago

Something non-obvious has changed between the current state of things and the nightly integration I'm about to complete, which causes shared array buffers to return a null pointer for their contents, which is triggering an assert in node. I'm disabling the test for now.

MSLaguana commented 6 years ago

I'm still not sure what change caused this to come to the surface, but it looks like the problem is we don't currently have a JSRT way to extract the contents of s SharedArrayBuffer; There are JsGetArrayBufferStorage and JsGetTypedArrayStorage but neither of those accept shared array buffers as inputs.

kfarnung commented 6 years ago

Disabled in 06ff556f9eb0c1c926b317373f17c8c12d8c08b8

MSLaguana commented 6 years ago

This is also impacting test-assert-typedarray-deepequal.js