search

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:
Other
1.92k stars 342 forks source link

Updating TTD options parsing to use new node_options APIs #587

Closed mike-kaufman closed 6 years ago

mike-kaufman commented 6 years ago
Checklist
kfarnung commented 6 years ago

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/307/

kfarnung commented 6 years ago

Looks like some linter failures: https://ci.nodejs.org/job/node-test-linter/21597/console

mike-kaufman commented 6 years ago

OK, think I fixed linter errors.

kfarnung commented 6 years ago

Restarted linter leg https://ci.nodejs.org/job/node-test-linter/21598/

kfarnung commented 6 years ago

Linter looks good now.