search

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:
Other
1.92k stars 342 forks source link

chakrashim: fix lint issue #591

Closed kfarnung closed 6 years ago

kfarnung commented 6 years ago
Checklist
sethbrenith commented 6 years ago

Looks fine, but this was just a copy from deps/v8/include/v8.h and I'm not sure why we would be stricter about our version of this file.

kfarnung commented 6 years ago

Interesting, I believe they have their own linter rules for V8 sources, but we just use the Node rules.

kfarnung commented 6 years ago

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/312/