Closed kfarnung closed 6 years ago
Isn't it useful to run the tests for non-bigInt cases? I did it for the pump in d4d1ef76f7. I'm fine with eval as well, but it likely will be a conflict.
I'm assuming these cases are covered elsewhere, these are specifically about testing bigint. This is based on the current master, so there should be no conflict.
If I understand it correctly, the tests validate equivalence of various types when used as keys/values (e.g. null and undefined). BigInts were added as yet another equivalence test.
Correct, but if we don't support bigints then the test isn't necessary for node-chakracore anyway.
Aren't you disabling the tests for undefined, null and falsies (as well as bigInt)? I don't like it that all of them are in the same bucket, should probably be separate (that, or I don't understand the tests).
Oh, I see now, it looks like they conflated these tests a bit. I think I'd rather just disable them rather than trying to duplicate their behavior without BigInt. That will keep merge conflicts to a minimum in the future.
OK. I'm fine with that.
Rebuild of the Windows job: https://ci.nodejs.org/job/chakracore-test-windows/492/ (failed in the test-PR above for unrelated reasons).
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes