search

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:
Other
1.92k stars 342 forks source link

src,test: enable `per_context.js` shim #600

Closed kfarnung closed 5 years ago

kfarnung commented 5 years ago

This change requires a new version of ChakraCore, making the change in chakracore-master branch for now to get some testing

This reverts commit f5d29d5ec3b90d4c6dfa03c40d77ae282ea4657c. It also updates the shim to use shim wake using notify.

Refs: https://github.com/nodejs/node-chakracore/issues/565 Refs: https://github.com/nodejs/node-chakracore/issues/567

Checklist
kfarnung commented 5 years ago

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/320/

MSLaguana commented 5 years ago

LGTM if tests pass; what changed to make the intl initialization not fatal? Does intl actually work if ICU isn't configured the first time we touch the intl object?

devsnek commented 5 years ago

glad to see this 🎉

just so you know, we're updating the Atomics shim upstream to flip it sorta like you did here, so there might be a merge conflict there at some point.

kfarnung commented 5 years ago

It will be a little while before this hits a nightly, but at least we should have everything ready when we are able to move to a newer version of ChakraCore.

kfarnung commented 5 years ago

@devsnek I grabbed the current state of https://github.com/nodejs/node/pull/22844 and applied that instead of my divergent change. PTAL if you have time.

kfarnung commented 5 years ago

Since the change just landed upstream, I'll just hold off for now and rebase on top of it. Thanks for taking a look!

kfarnung commented 5 years ago

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/324/