chakrashim: enable `resourceNameToUrl` support - Githubissues

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:

Other

1.92k stars 342 forks source link

chakrashim: enable `resourceNameToUrl` support #601

Closed kfarnung closed 5 years ago

kfarnung commented 5 years ago

Wired up support for calling the node-provided resourceNameToUrl method in the chakrashim inspector.

This reverts commit 3f6ef13890ac89779f36af5eb3ea276b617f8447.

Fixes: https://github.com/nodejs/node-chakracore/issues/598 Refs: https://github.com/nodejs/node/pull/22251 Refs: https://github.com/nodejs/node-chakracore/commit/3f6ef13890ac89779f36af5eb3ea276b617f8447

Checklist

[x] make -j4 test (UNIX), or vcbuild test (Windows) passes
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message follows commit guidelines

kfarnung commented 5 years ago

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/322/

kfarnung commented 5 years ago

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/323/