search

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:
Other
1.92k stars 342 forks source link

--v8-options not working #612

Closed chopdown closed 5 years ago

chopdown commented 5 years ago

It works on node-chakracore-v10.6.0. Commit: https://github.com/nodejs/node-chakracore/commit/29a71bae40ffa0bbc8ba6b2bdf051a09987da7f7 remove this implementation. It's need by v8flags, depend by gulp module. Hope this will be implemented.

kfarnung commented 5 years ago

Good catch, this was missed when taking in the latest changes from upstream. It should be relatively simple to implement the missing function:

https://github.com/nodejs/node-chakracore/blob/38520056313bc747e3ca6dcc7598c2e51394c0ac/deps/chakrashim/src/v8v8.cc#L108-L110

chopdown commented 5 years ago

I implemented a version, make things work, but not sure the original intention.

kfarnung commented 5 years ago

The fix looks good to me, thanks for the quick PR!