search

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:
Other
1.92k stars 341 forks source link

node.gyp: hard coded include v8.h #92

Open jianchun opened 8 years ago

jianchun commented 8 years ago

Some recent changes caused hard coded v8.h:

https://github.com/nodejs/node-chakracore/blob/chakracore-master/node.gyp#L209

        'deps/v8/include/v8.h',
        'deps/v8/include/v8-debug.h',
jianchun commented 8 years ago

Please compare with master node.gyp. Some other parts may need sync too. e.g. official v8 deps is now authored as

        [ 'node_use_bundled_v8=="true"', {
          'dependencies': [
            'deps/v8/tools/gyp/v8.gyp:v8',
            'deps/v8/tools/gyp/v8.gyp:v8_libplatform'
          ],
        }],
kunalspathak commented 8 years ago

Some recent changes caused hard coded v8.h:

Seems that it was hard coded from day 1. I will look into it to see what can be done.

jianchun commented 8 years ago

I seem to recall moved them under node_engine=="v8" at some point, maybe change lost long ago.

kfarnung commented 7 years ago

@kunalspathak Can you take a look?