Ensure chakrashim extracts information from right context

nodejs / node-chakracore

Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:

Other

1.92k stars 341 forks source link

Ensure chakrashim extracts information from right context #95

Open kunalspathak opened 8 years ago

kunalspathak commented 8 years ago

Version:
Platform:
Subsystem:

As mentioned in recent PR #96, for repl scenario we were not extracting the global object from right context. Instead we simply extracted from current context leading to new context being collected. There are multiple places where we do one of 2 things that needs to be reviewed.

IsolateShim::GetCurrent()->GetCurrentContextShim();
jsrt::ContextShim::GetCurrent()

digitalinfinity commented 7 years ago

@kunalspathak I see several commits that referenced this issue- do you know if this still needs to be fixed or whether it can be closed?

kunalspathak commented 7 years ago

Commits 983c0b8 and 0125f12 just points to the severity/implication around this issue. This definitely need to be fixed.

digitalinfinity commented 7 years ago

Ok, thanks