search

nodejs / node-core-test

Node 18's node:test, as an npm package
Other
95 stars 10 forks source link

test: tweak test:lint command + add test:lint:fix #15

Closed bnb closed 2 years ago

bnb commented 2 years ago

This PR updates the lint:test command, removing the --fix flag from it, and adds a test:lint:fix command, which has the same functionality as the old lint:test.

Others might have differing opinions, but in my experience I really don't usually want my default test command (that's used by other commands and is often something people run immediately when they clone/are trying to make a PR) to be making code changes.

Figured I'd throw up a quick PR for this. If including --fix is a desired approach, feel free to close this PR.

juliangruber commented 2 years ago

Thank you for the PR, @bnb! Having the test script also format code is my preferred approach, I'm happy to merge though if more people agree with this PR