search

nodejs / node-core-test

Node 18's node:test, as an npm package
Other
95 stars 10 forks source link

3.2.0 fails in node 14 #35

Closed juliangruber closed 2 years ago

juliangruber commented 2 years ago

See eg https://github.com/juliangruber/parse-apache-directory-index/pull/28

/Users/julian/dev/juliangruber/parse-apache-directory-index/node_modules/test/lib/internal/abort_controller.js:4
  AbortController,
  ^

ReferenceError: AbortController is not defined
    at Object.<anonymous> (/Users/julian/dev/juliangruber/parse-apache-directory-index/node_modules/test/lib/internal/abort_controller.js:4:3)

I wonder why tests didn't catch this. Is it because we pass our own AbortController implementation?

aduh95 commented 2 years ago

There's catch in the README: https://github.com/nodejs/node-core-test/blob/1401584d141b73bab022995f09245436f10727f4/README.md#L14

aduh95 commented 2 years ago

And here's how we're testing it: https://github.com/nodejs/node-core-test/blob/558abfc9a691e02f191c61ba16b976c9d5604da1/.github/workflows/ci.yml#L10-L14 https://github.com/nodejs/node-core-test/blob/558abfc9a691e02f191c61ba16b976c9d5604da1/.github/workflows/ci.yml#L21-L23

juliangruber commented 2 years ago

Aah right I forgot about that. Thank you for pointing this out. I think this should have been a major version bump then.

juliangruber commented 2 years ago

shall we deprecate 3.2.0 and publish 4.0.0?