nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
234 stars 106 forks source link

WIP: ncu-contrib: initial implementation #186

Closed joyeecheung closed 3 years ago

joyeecheung commented 6 years ago

Currently two types of contribution profiles are available:

  1. Participations (comments, reviews, PRs, opened issues, across the whole nodejs organization). The displayed result are the latest participations of the selected group.
screen shot 2018-02-21 at 7 44 02 am
  1. Commits (by default, commits on the master branch of nodejs/node). The displayed result are the latest commits of the selected group. screen shot 2018-02-21 at 7 44 22 am

The group can be:

  1. collaborators
  2. tsc
  3. Array of GitHub handles
ncu-contrib <command>

Commands:
  ncu-contrib collaborators  Getting contributions from collaborators
  ncu-contrib tsc            Getting contributions from TSC members
  ncu-contrib for <ids..>    Getting contributions from GitHub handles

Options:
  --version  Show version number                                       [boolean]
  --help     Show help                                                 [boolean]
  --repo                                              [string] [default: "node"]
  --owner                                           [string] [default: "nodejs"]
  --type                                     [string] [default: "participation"]
  --branch                                          [string] [default: "master"]
joyeecheung commented 6 years ago

Refs: https://github.com/nodejs/node/issues/18879

This needs some tests to land...also I plan to reuse some bits of it to implement the nomination template proposed in https://github.com/nodejs/node/issues/18090#issuecomment-356932254

alopezsanchez commented 6 years ago

Nice work!

I can do the tests if you give me a few days (I have not much time ATM).

joyeecheung commented 6 years ago

@alopezsanchez Thanks, I'll first play with it for a few days to make sure this covers what I want as the initial implementation, then it'll be more ready to test. I still need to figure out how to make the cache work properly (I don't really think the users need them, they are mostly for developing and debugging)

benjamingr commented 6 years ago

Very nice, who does it bring up at the moment as no activity in the last year?

joyeecheung commented 6 years ago

Some feedback I've gathered:

  1. Need to add options to account for Reviewed-By fields in--type commit
  2. authoredDate -> committedDate in--type commit
  3. Would be nice if there are some percentiles

@benjamingr I have posted my findings in https://github.com/nodejs/node/issues/18879#issuecomment-367620905 , don't want to post the names in public but I can send you a gist if you want to see the list.

codecov[bot] commented 6 years ago

Codecov Report

Merging #186 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files          19       19           
  Lines         723      723           
=======================================
  Hits          640      640           
  Misses         83       83

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3dafebf...d30abc5. Read the comment docs.

codebytere commented 3 years ago

@joyeecheung do you think you still plan to work on this, or may it be closed as abandoned?

github-actions[bot] commented 3 years ago

This PR is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

codebytere commented 3 years ago

Closing but if someone would like to pick this up again please reopen :)