Closed joyeecheung closed 3 years ago
Refs: https://github.com/nodejs/node/issues/18879
This needs some tests to land...also I plan to reuse some bits of it to implement the nomination template proposed in https://github.com/nodejs/node/issues/18090#issuecomment-356932254
Nice work!
I can do the tests if you give me a few days (I have not much time ATM).
@alopezsanchez Thanks, I'll first play with it for a few days to make sure this covers what I want as the initial implementation, then it'll be more ready to test. I still need to figure out how to make the cache work properly (I don't really think the users need them, they are mostly for developing and debugging)
Very nice, who does it bring up at the moment as no activity in the last year?
Some feedback I've gathered:
Reviewed-By
fields in--type commit
authoredDate
-> committedDate
in--type commit
@benjamingr I have posted my findings in https://github.com/nodejs/node/issues/18879#issuecomment-367620905 , don't want to post the names in public but I can send you a gist if you want to see the list.
Merging #186 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 19 19
Lines 723 723
=======================================
Hits 640 640
Misses 83 83
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3dafebf...d30abc5. Read the comment docs.
@joyeecheung do you think you still plan to work on this, or may it be closed as abandoned?
This PR is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.
Closing but if someone would like to pick this up again please reopen :)
Currently two types of contribution profiles are available:
The group can be:
collaborators
tsc