Feature/url parsing

[Tiriel]

Please feel free to suggest changes!

From #22 :

• [x] Add yargs
• [x] General name and purpose of the command
• [x] Basic usage example
• [x] Arguments details

From #25 :

• [x] When first arg is url, extract owner, repo, and pr-id from it
• When first arg is integer:
  • [x] Check second arg for owner and third arg for repo if given
  • [x] Default owner to nodejs and repo to node if not
  • [x] Allow args to be given in any other order when named? (--repo=node --owner=nodejs)

I have tried to test it manually, seems to be working as expected!

[codecov-io]

Codecov Report

Merging #30 into master will increase coverage by 0.13%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   96.41%   96.54%   +0.13%     
==========================================
  Files          12       13       +1     
  Lines         418      434      +16     
==========================================
+ Hits          403      419      +16     
  Misses         15       15

Impacted Files	Coverage Δ
lib/args.js	100% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54b1004...8623a70. Read the comment docs.

[Tiriel]

Fixed lint! Sorry, don't know why my IDE linted it that way...

[joyeecheung]

I have given it a try and looks like it's not working as intended...

[joyeecheung]

Also..we don't have a test for CLI, that's why this passes travis. I think we should get some tests in before this lands.

[Tiriel]

True that.

<edited, spoke too quickly> I'm going to see what I can do for testing!

[Tiriel]

Okay. Lint ok, tests ok, build ok... At last.

Sorry for the messy work, not used to this sort of thing yet, learning. Good for review I guess!

[joyeecheung]

@Tiriel I have merged the refactoring PR, there is a conflict now, can you rebase?

[joyeecheung]

BTW this is how you can rebase

$ git checkout feature/url-parsing
$ git fetch upstream # assuming upstream points to this repo
$ git rebase upstream/master
# fix conflicts
$ git push --force origin feature/url-parsing  # assuming origin points to your fork

[Tiriel]

No problem, doing it right now! And thanks for the tip.

[Tiriel]

Done!

Linted, tests passing on my local, command working as far as I can tell!

[joyeecheung]

Awesome work! Thanks!