nodejs / node-core-utils

CLI tools for Node.js Core collaborators

https://nodejs.github.io/node-core-utils/

MIT License

234 stars 106 forks source link

travis: test on Windows #314

Closed targos closed 4 years ago

targos commented 5 years ago

Fixes: https://github.com/nodejs/node-core-utils/issues/313

targos commented 5 years ago

Let's see if it works

codecov[bot] commented 5 years ago

Codecov Report

Merging #314 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #314   +/-   ##
======================================
  Coverage    74.1%   74.1%           
======================================
  Files          22      22           
  Lines        1398    1398           
======================================
  Hits         1036    1036           
  Misses        362     362

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4d10ed...e6b80cc. Read the comment docs.

targos commented 5 years ago

Some tests fail because of CRLF.

targos commented 5 years ago

Should we make the matrix a bit lighter? Maybe test with all node versions on Linux and only one on Windows and Mac?

joyeecheung commented 5 years ago

@targos

Should we make the matrix a bit lighter? Maybe test with all node versions on Linux and only one on Windows and Mac?

Which one though? (I'd guess...11? Since people who uses this tend to live near the edge I guess..)

joyeecheung commented 5 years ago

I think adding these to .gitattributes should fix the Windows issue?

# auto detect text files
* text=auto

# we don't have actual binary files in this repo so just checkout everything with LF
*.* text eol=lf

targos commented 5 years ago

I changed the matrix and created .gitattributes: https://github.com/nodejs/node-core-utils/pull/314/checks

targos commented 5 years ago

still failing on Windows... let me debug that on my machine.

targos commented 5 years ago

I cannot reproduce on my Windows machine

targos commented 5 years ago

Rebased. @joyeecheung do you think we still need the .gitattributes?

targos commented 5 years ago

There seems to still be issues with CRLF

joyeecheung commented 5 years ago

Can you rebase and force push to see if Travis can pick the other fix up?

targos commented 5 years ago

@joyeecheung it's what I did

joyeecheung commented 5 years ago

@targos ah, sorry, didn't see the history (was on mobile)

joyeecheung commented 5 years ago

The previous green Windows I got is on travis-ci.org instead of travis-ci.com, I wonder if that makes a difference... https://travis-ci.org/joyeecheung/node-core-utils/jobs/462560512

Also, looks like the failing tests are all comparing output to raw files contents, instead of e.g. parsed JSONs (EDIT: oh, but \r\n in strings in the JSON still make a difference)