nodejs / node-core-utils

CLI tools for Node.js Core collaborators

https://nodejs.github.io/node-core-utils/

MIT License

234 stars 106 forks source link

Add functionality for daily-master to NCU-CI #379

Closed AshCripps closed 3 years ago

AshCripps commented 4 years ago

@sam-github heres my draft for what I have so far.

sam-github commented 4 years ago

For context: we're looking to get ncu-ci running against daily builds, because, by definition, any failure on master is either a failure in the infrastructure, or a flaky test.

sam-github commented 3 years ago

We're trying to figure out if we should push it forward because its useful and achievable, or perhaps whether its a bit of an improvement already and can be merged, or perhaps it was just an interesting experiment and we should abandon it.

@joyeecheung what do you think?

joyeecheung commented 3 years ago

@sam-github Is there a summary of what this does? AFAICT it just adds some logic so that the command can be used on daily build data and it adds some logic to make it more fail-safe?

sam-github commented 3 years ago

The intention was just this,

adds some logic so that the command can be used on daily build data

but maybe some other logic was added as needed.

joyeecheung commented 3 years ago

@sam-github I think this should be good to get in with the commented code removed

codecov[bot] commented 3 years ago

Codecov Report

Merging #379 into master will decrease coverage by 2.32%. The diff coverage is 32.25%.

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   77.35%   75.03%   -2.33%     
==========================================
  Files          21       21              
  Lines        1572     1626      +54     
==========================================
+ Hits         1216     1220       +4     
- Misses        356      406      +50

Impacted Files	Coverage Δ
lib/ci/ci_result_parser.js	`48.14% <30.00%> (-4.31%)`	:arrow_down:
lib/ci/ci_type_parser.js	`81.53% <100.00%> (+0.28%)`	:arrow_up:
lib/cli.js	`90.41% <0.00%> (+1.67%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5fe936f...0d29c59. Read the comment docs.

AshCripps commented 3 years ago

ive rebased and removed the commented code.

AshCripps commented 3 years ago

Can this be landed? I dont have permission to merge.

richardlau commented 3 years ago

Can this be landed? I dont have permission to merge.

cc @nodejs/automation-collaborators

AshCripps commented 3 years ago

Ive rebased this against master so is free to be landed again