search

nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
255 stars 113 forks source link

Erroneous "Commit message is missing PR-URL" error #506

Open codebytere opened 4 years ago

codebytere commented 4 years ago

Seen here: https://github.com/nodejs/node/pull/35405

When i proceed anyway, each message nevertheless has all requisite info:

node on git:v12.x-staging ❯ git rebase upstream/v12.x-staging -i -x "git node land --amend"
Executing: git node land --amend
   ⚠  Found PR-URL: , skipping..
--------------------------------- New Message ----------------------------------
module: named exports for CJS via static analysis

PR-URL: https://github.com/nodejs/node/pull/35249
Backport-PR-URL: https://github.com/nodejs/node/pull/35405
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
--------------------------------------------------------------------------------
? Use this message? Yes
[detached HEAD 65ffce152b] module: named exports for CJS via static analysis
 Author: Guy Bedford <guybedford@gmail.com>
 Date: Thu May 14 22:40:37 2020 -0700
 20 files changed, 1926 insertions(+), 85 deletions(-)
 create mode 100755 deps/cjs-module-lexer/.gitignore
 create mode 100755 deps/cjs-module-lexer/LICENSE
 create mode 100755 deps/cjs-module-lexer/README.md
 create mode 100755 deps/cjs-module-lexer/lexer.js
 create mode 100755 deps/cjs-module-lexer/package.json
 create mode 100644 test/es-module/test-esm-cjs-exports.js
 create mode 100644 test/fixtures/es-modules/cjs-exports.mjs
 create mode 100644 test/fixtures/es-modules/exports-cases.js
 create mode 100644 test/fixtures/es-modules/exports-cases2.js
 create mode 100644 test/fixtures/es-modules/exports-cases3.js
Executing: git node land --amend
   ⚠  Found PR-URL: , skipping..
github-actions[bot] commented 3 years ago

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.