nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
255 stars 113 forks source link

git node land just hangs #599

Open panva opened 2 years ago

panva commented 2 years ago

I am unable to land PRs since a few months ago. I've tried issuing new credentials as well as different PRs. This happens for me on every PR.

Logs & Details ![Kapture 2021-12-17 at 10 52 04-min](https://user-images.githubusercontent.com/241506/146526212-182a0e45-d50b-4593-be0c-e0947e45d5cd.gif) ``` NCU_VERBOSITY=debug git node land 41170 [DEBUG] [SpawnSync] git config --get remote.upstream.url { cwd: '/Users/panva/repo/node' } [DEBUG] [SpawnSync] git rev-parse --abbrev-ref HEAD { cwd: '/Users/panva/repo/node' } [DEBUG] [SpawnSync] git rev-parse --abbrev-ref HEAD { cwd: '/Users/panva/repo/node' } [DEBUG] [fetch] https://api.github.com/graphql [DEBUG] [SpawnSync] git config --get remote.upstream.url { cwd: '/Users/panva/repo/node' } ⠋ Loading data for nodejs/node/pull/41170 [DEBUG] [fetch] https://raw.githubusercontent.com/nodejs/node/HEAD/README.md [DEBUG] [fetch] https://api.github.com/graphql [DEBUG] [fetch] https://api.github.com/graphql [DEBUG] [fetch] https://api.github.com/graphql [DEBUG] [fetch] https://api.github.com/graphql ✔ Done loading data for nodejs/node/pull/41170 ----------------------------------- PR info ------------------------------------ Title tls: permit null as a pfx value (#41170) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch CallMeLaNN:fix/pfx-cant-load -> nodejs:master Labels tls, author ready, commit-queue-failed Commits 2 - tls: permit null as a pfx value - tls: permit null as an options value Committers 1 - CallMeLaNN ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41170 Fixes: https://github.com/nodejs/node/issues/36292 Reviewed-By: Matteo Collina Reviewed-By: Filip Skokan -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 14 Dec 2021 13:57:39 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41170#pullrequestreview-832783699 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/41170#pullrequestreview-832785694 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-12-17T09:42:04Z: https://ci.nodejs.org/job/node-test-pull-request/41511/ ⠋ Querying data for job/node-test-pull-request/41511/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ⠴ Querying API for job/node-test-pull-request/41511/ ```
targos commented 2 years ago

I thought there was already an issue for it. This happens for everyone, I think, but it doesn't prevent you from landing PRs. The issue is that you have to answer a question which it is not displayed. Just press Y + Enter and it should work.

panva commented 2 years ago

OK.