Closed aduh95 closed 1 year ago
May be interesting to look at the logs of the worflow
The workflow logs are available at https://github.com/nodejs/node/runs/7530255401?check_suite_focus=true
- Loading data for nodejs/node/pull/43974 2022-07-26T22:37:58.6175855Zhttps://github.com/nodejs/node/actions/runs/2742944880Commit Queue failed
- Loading data for nodejs/node/pull/43974 2022-07-26T22:37:58.6176646Z ✔ Done loading data for nodejs/node/pull/43974 2022-07-26T22:37:58.6177163Z ✔ Done loading data for nodejs/node/pull/43974 2022-07-26T22:37:58.6177990Z ----------------------------------- PR info ------------------------------------ 2022-07-26T22:37:58.6179015Z ----------------------------------- PR info ------------------------------------ 2022-07-26T22:37:58.6179747Z Title http: make idle http parser count configurable (#43974) 2022-07-26T22:37:58.6180280Z Title http: make idle http parser count configurable (#43974) 2022-07-26T22:37:58.6180935Z Author theanarkhhttps://github.com/nodejs/node/actions/runs/2742944880(@theanarkh) 2022-07-26T22:37:58.6181422Z Author theanarkh (@theanarkh) 2022-07-26T22:37:58.6182232Z Branch theanarkh:make_idle_http_parser_count_configurable -> nodejs:main 2022-07-26T22:37:58.6182921Z Branch theanarkh:make_idle_http_parser_count_configurable -> nodejs:main 2022-07-26T22:37:58.6183588Z Labels http, author ready, needs-ci 2022-07-26T22:37:58.6184053Z Labels http, author ready, needs-ci 2022-07-26T22:37:58.6187477Z Commits 1 2022-07-26T22:37:58.6187933Z - http: make idle http parser count configurable 2022-07-26T22:37:58.6188255Z Committers 1 2022-07-26T22:37:58.6188643Z - theanarkh 2022-07-26T22:37:58.6189183Z PR-URL: https://github.com/nodejs/node/pull/43974 2022-07-26T22:37:58.6189713Z Reviewed-By: Paolo Insogna 2022-07-26T22:37:58.6190281Z Reviewed-By: Matteo Collina 2022-07-26T22:37:58.6190969Z ------------------------------ Generated metadata ------------------------------ 2022-07-26T22:37:58.6191572Z PR-URL: https://github.com/nodejs/node/pull/43974 2022-07-26T22:37:58.6192274Z Reviewed-By: Paolo Insogna 2022-07-26T22:37:58.6192826Z Reviewed-By: Matteo Collina 2022-07-26T22:37:58.6193160Z Commits 1 2022-07-26T22:37:58.6193954Z -------------------------------------------------------------------------------- 2022-07-26T22:37:58.6194514Z ⚠ Commits were pushed since the last review: 2022-07-26T22:37:58.6195010Z - http: make idle http parser count configurable 2022-07-26T22:37:58.6195672Z ⚠ - http: make idle http parser count configurable 2022-07-26T22:37:58.6195999Z Committers 1 2022-07-26T22:37:58.6196573Z ℹ This PR was created on Sun, 24 Jul 2022 21:20:46 GMT 2022-07-26T22:37:58.6197025Z - theanarkh 2022-07-26T22:37:58.6197527Z ✔ Approvals: 2 2022-07-26T22:37:58.6198030Z PR-URL: https://github.com/nodejs/node/pull/43974 2022-07-26T22:37:58.6198910Z ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/43974#pullrequestreview-1048934026 2022-07-26T22:37:58.6199551Z Reviewed-By: Paolo Insogna 2022-07-26T22:37:58.6200394Z ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43974#pullrequestreview-1048975913 2022-07-26T22:37:58.6201068Z Reviewed-By: Matteo Collina 2022-07-26T22:37:58.6201630Z ✔ Last GitHub CI successful 2022-07-26T22:37:58.6202267Z ------------------------------ Generated metadata ------------------------------ 2022-07-26T22:37:58.6203182Z ℹ Last Full PR CI on 2022-07-25T14:36:15Z: https://ci.nodejs.org/job/node-test-pull-request/45670/ 2022-07-26T22:37:58.6203829Z PR-URL: https://github.com/nodejs/node/pull/43974 2022-07-26T22:37:58.6204536Z - Querying data for job/node-test-pull-request/45670/ 2022-07-26T22:37:58.6205079Z Reviewed-By: Paolo Insogna 2022-07-26T22:37:58.6205836Z ✔ Last Jenkins CI successful 2022-07-26T22:37:58.6206358Z Reviewed-By: Matteo Collina 2022-07-26T22:37:58.6207160Z -------------------------------------------------------------------------------- 2022-07-26T22:37:58.6207865Z -------------------------------------------------------------------------------- 2022-07-26T22:37:58.6209036Z ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu 2022-07-26T22:37:58.6209741Z ⚠ Commits were pushed since the last review: 2022-07-26T22:37:58.6210240Z ⚠ - http: make idle http parser count configurable 2022-07-26T22:37:58.6211207Z + echo
2022-07-26T22:37:58.6224635Z PR-URL: https://github.com/nodejs/node/pull/43974 2022-07-26T22:37:58.6225276Z Reviewed-By: Paolo Insogna paolo@cowtech.it 2022-07-26T22:37:58.6225919Z Reviewed-By: Matteo Collina matteo.collina@gmail.com 2022-07-26T22:37:58.6226687Z ------------------------------ Generated metadata ------------------------------ 2022-07-26T22:37:58.6227391Z PR-URL: https://github.com/nodejs/node/pull/43974 2022-07-26T22:37:58.6228014Z Reviewed-By: Paolo Insogna paolo@cowtech.it 2022-07-26T22:37:58.6228661Z Reviewed-By: Matteo Collina matteo.collina@gmail.com 2022-07-26T22:37:58.6229456Z -------------------------------------------------------------------------------- 2022-07-26T22:37:58.6230108Z ⚠ Commits were pushed since the last review: 2022-07-26T22:37:58.6230704Z ⚠ - http: make idle http parser count configurable 2022-07-26T22:37:58.6236173Z ℹ This PR was created on Sun, 24 Jul 2022 21:20:46 GMT 2022-07-26T22:37:58.6236714Z ✔ Approvals: 2 2022-07-26T22:37:58.6237405Z ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/43974#pullrequestreview-1048934026 2022-07-26T22:37:58.6238239Z ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43974#pullrequestreview-1048975913 2022-07-26T22:37:58.6238773Z ✔ Last GitHub CI successful 2022-07-26T22:37:58.6239626Z ℹ Last Full PR CI on 2022-07-25T14:36:15Z: https://ci.nodejs.org/job/node-test-pull-request/45670/ 2022-07-26T22:37:58.6240284Z - Querying data for job/node-test-pull-request/45670/ 2022-07-26T22:37:58.6240739Z ✔ Last Jenkins CI successful 2022-07-26T22:37:58.6241372Z -------------------------------------------------------------------------------- 2022-07-26T22:37:58.6242418Z ✔ AbortedCommit Queue failed
- Loading data for nodejs/node/pull/43974 2022-07-26T22:37:58.6211806Z ℹ This PR was created on Sun, 24 Jul 2022 21:20:46 GMT 2022-07-26T22:37:58.6212490Z ✔ Done loading data for nodejs/node/pull/43974 2022-07-26T22:37:58.6213161Z ----------------------------------- PR info ------------------------------------ 2022-07-26T22:37:58.6213596Z ✔ Approvals: 2 2022-07-26T22:37:58.6214193Z Title http: make idle http parser count configurable (#43974) 2022-07-26T22:37:58.6214932Z ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/43974#pullrequestreview-1048934026 2022-07-26T22:37:58.6215664Z Author theanarkh theratliter@gmail.com (@theanarkh) 2022-07-26T22:37:58.6216392Z ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43974#pullrequestreview-1048975913 2022-07-26T22:37:58.6217273Z Branch theanarkh:make_idle_http_parser_count_configurable -> nodejs:main 2022-07-26T22:37:58.6217749Z ✔ Last GitHub CI successful 2022-07-26T22:37:58.6218331Z Labels http, author ready, needs-ci 2022-07-26T22:37:58.6219006Z ℹ Last Full PR CI on 2022-07-25T14:36:15Z: https://ci.nodejs.org/job/node-test-pull-request/45670/ 2022-07-26T22:37:58.6219555Z Commits 1 2022-07-26T22:37:58.6220062Z - Querying data for job/node-test-pull-request/45670/ 2022-07-26T22:37:58.6220708Z - http: make idle http parser count configurable 2022-07-26T22:37:58.6221143Z ✔ Last Jenkins CI successful 2022-07-26T22:37:58.6221555Z Committers 1 2022-07-26T22:37:58.6222157Z -------------------------------------------------------------------------------- 2022-07-26T22:37:58.6222786Z - theanarkh theratliter@gmail.com 2022-07-26T22:37:58.6223780Z ✔ Abortedhttps://github.com/nodejs/node/actions/runs/2742944880git node land
session in /home/runner/work/node/node/.ncugit node land
session in /home/runner/work/node/node/.ncu
- Loading data for nodejs/node/pull/43974
2022-07-26T22:37:58.6244176Z ✔ Done loading data for nodejs/node/pull/43974
2022-07-26T22:37:58.6244842Z ----------------------------------- PR info ------------------------------------
2022-07-26T22:37:58.6245404Z Title http: make idle http parser count configurable (#43974)
2022-07-26T22:37:58.6245932Z Author theanarkh theratliter@gmail.com (@theanarkh)
2022-07-26T22:37:58.6246582Z Branch theanarkh:make_idle_http_parser_count_configurable -> nodejs:main
2022-07-26T22:37:58.6247109Z Labels http, author ready, needs-ci
2022-07-26T22:37:58.6247413Z Commits 1
2022-07-26T22:37:58.6247839Z - http: make idle http parser count configurable
2022-07-26T22:37:58.6248155Z Committers 1
2022-07-26T22:37:58.6248537Z - theanarkh theratliter@gmail.com
2022-07-26T22:37:58.6249054Z PR-URL: https://github.com/nodejs/node/pull/43974
2022-07-26T22:37:58.6249576Z Reviewed-By: Paolo Insogna paolo@cowtech.it
2022-07-26T22:37:58.6250124Z Reviewed-By: Matteo Collina matteo.collina@gmail.com
2022-07-26T22:37:58.6250798Z ------------------------------ Generated metadata ------------------------------
2022-07-26T22:37:58.6251400Z PR-URL: https://github.com/nodejs/node/pull/43974
2022-07-26T22:37:58.6251922Z Reviewed-By: Paolo Insogna paolo@cowtech.it
2022-07-26T22:37:58.6252473Z Reviewed-By: Matteo Collina matteo.collina@gmail.com
2022-07-26T22:37:58.6253131Z --------------------------------------------------------------------------------
2022-07-26T22:37:58.6253673Z ⚠ Commits were pushed since the last review:
2022-07-26T22:37:58.6254163Z ⚠ - http: make idle http parser count configurable
2022-07-26T22:37:58.6254676Z ℹ This PR was created on Sun, 24 Jul 2022 21:20:46 GMT
2022-07-26T22:37:58.6255038Z ✔ Approvals: 2
2022-07-26T22:37:58.6255689Z ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/43974#pullrequestreview-1048934026
2022-07-26T22:37:58.6256514Z ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43974#pullrequestreview-1048975913
2022-07-26T22:37:58.6257043Z ✔ Last GitHub CI successful
2022-07-26T22:37:58.6257691Z ℹ Last Full PR CI on 2022-07-25T14:36:15Z: https://ci.nodejs.org/job/node-test-pull-request/45670/
2022-07-26T22:37:58.6258334Z - Querying data for job/node-test-pull-request/45670/
2022-07-26T22:37:58.6258783Z ✔ Last Jenkins CI successful
2022-07-26T22:37:58.6259404Z --------------------------------------------------------------------------------
2022-07-26T22:37:58.6260446Z ✔ Aborted git node land
session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/2742944880git node land
session in /home/runner/work/node/node/.ncu
2022-07-26T22:38:01.1023140Z + continue
2022-07-26T22:38:01.1023750Z + gh pr view 43971 --json labels --jq .labels
2022-07-26T22:38:01.4229961Z + jq -e map(.name) | index("request-ci")
2022-07-26T22:38:01.4553824Z null
2022-07-26T22:38:01.4557905Z + gh pr+ checks 43971
2022-07-26T22:38:01.4559004Z grep -q \spending\s
2022-07-26T22:38:02.0040581Z + gh pr edit 43971 --remove-label commit-queue
2022-07-26T22:38:04.6491936Z https://github.com/nodejs/node/pull/43971
2022-07-26T22:38:04.6508460Z + jq -e map(.name) | index("commit-queue-squash")
2022-07-26T22:38:04.6834587Z null
2022-07-26T22:38:04.6836613Z + jq -e map(.name) | index("commit-queue-rebase")
2022-07-26T22:38:04.7148790Z null
2022-07-26T22:38:04.7150797Z + MULTIPLE_COMMIT_POLICY=--oneCommitMax
2022-07-26T22:38:04.7151547Z + git node land --autorebase --yes --oneCommitMax 43971
2022-07-26T22:38:07.3186113Z + cat output
2022-07-26T22:38:07.3196419Z - Loading data for nodejs/node/pull/43971
2022-07-26T22:38:07.3197115Z ✔ Done loading data for nodejs/node/pull/43971
2022-07-26T22:38:07.3197650Z + grep -q . Post "Landed in ./pull/43971 output
2022-07-26T22:38:07.3198328Z ----------------------------------- PR info ------------------------------------
2022-07-26T22:38:07.3199068Z Title test: remove test-gc-http-client-timeout from flaky list (#43971)
2022-07-26T22:38:07.3199602Z Author Feng Yu F3n67u@outlook.com (@F3n67u)
2022-07-26T22:38:07.3200140Z Branch F3n67u:remove-flaky -> nodejs:main
2022-07-26T22:38:07.3200637Z Labels test, author ready, needs-ci
2022-07-26T22:38:07.3201003Z Commits 1
2022-07-26T22:38:07.3201518Z - test: remove test-gc-http-client-timeout from flaky list
2022-07-26T22:38:07.3201908Z Committers 1
2022-07-26T22:38:07.3202316Z - Feng Yu F3n67u@outlook.com
2022-07-26T22:38:07.3202853Z PR-URL: https://github.com/nodejs/node/pull/43971
2022-07-26T22:38:07.3203346Z Refs: https://github.com/nodejs/node/pull/43949
2022-07-26T22:38:07.3203912Z Reviewed-By: Tobias Nießen tniessen@tnie.de
2022-07-26T22:38:07.3204463Z Reviewed-By: Luigi Pinca luigipinca@gmail.com
2022-07-26T22:38:07.3205021Z Reviewed-By: Chengzhong Wu legendecas@gmail.com
2022-07-26T22:38:07.3205564Z Reviewed-By: Darshan Sen raisinten@gmail.com
2022-07-26T22:38:07.3206239Z ------------------------------ Generated metadata ------------------------------
2022-07-26T22:38:07.3206859Z PR-URL: https://github.com/nodejs/node/pull/43971
2022-07-26T22:38:07.3207351Z Refs: https://github.com/nodejs/node/pull/43949
2022-07-26T22:38:07.3207892Z Reviewed-By: Tobias Nießen tniessen@tnie.de
2022-07-26T22:38:07.3208432Z Reviewed-By: Luigi Pinca luigipinca@gmail.com
2022-07-26T22:38:07.3208981Z Reviewed-By: Chengzhong Wu legendecas@gmail.com
2022-07-26T22:38:07.3209518Z Reviewed-By: Darshan Sen raisinten@gmail.com
2022-07-26T22:38:07.3209966Z + [ -z --oneCommitMax ]
2022-07-26T22:38:07.3210506Z --------------------------------------------------------------------------------
2022-07-26T22:38:07.3211149Z ℹ This PR was created on Sun, 24 Jul 2022 14:33:41 GMT
2022-07-26T22:38:07.3211671Z + git log -1 --pretty=format:%s
2022-07-26T22:38:07.3212160Z ✔ Approvals: 4
2022-07-26T22:38:07.3212848Z ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43971#pullrequestreview-1048652141
2022-07-26T22:38:07.3213882Z ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43971#pullrequestreview-1048654802
2022-07-26T22:38:07.3214668Z ✔ - Chengzhong Wu (@legendecas): https://github.com/nodejs/node/pull/43971#pullrequestreview-1048659219
2022-07-26T22:38:07.3215450Z ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43971#pullrequestreview-1048859564
2022-07-26T22:38:07.3215988Z ✔ Last GitHub CI successful
2022-07-26T22:38:07.3216640Z ℹ Last Full PR CI on 2022-07-26T04:44:06Z: https://ci.nodejs.org/job/node-test-pull-request/45652/
2022-07-26T22:38:07.3217299Z - Querying data for job/node-test-pull-request/45652/
2022-07-26T22:38:07.3217871Z ✔ Last Jenkins CI successful
2022-07-26T22:38:07.3218518Z --------------------------------------------------------------------------------
2022-07-26T22:38:07.3219047Z ✔ No git cherry-pick in progress
2022-07-26T22:38:07.3219585Z ✔ No git am in progress
2022-07-26T22:38:07.3220678Z ✔ No git rebase in progress
2022-07-26T22:38:07.3221233Z --------------------------------------------------------------------------------
2022-07-26T22:38:07.3221699Z - Bringing origin/main up to date...
2022-07-26T22:38:07.3222059Z From https://github.com/nodejs/node
2022-07-26T22:38:07.3222473Z branch main -> FETCH_HEAD
2022-07-26T22:38:07.3222863Z ✔ origin/main is now up-to-date
2022-07-26T22:38:07.3223223Z - Downloading patch for 43971
2022-07-26T22:38:07.3223569Z From https://github.com/nodejs/node
2022-07-26T22:38:07.3224013Z branch refs/pull/43971/merge -> FETCH_HEAD
2022-07-26T22:38:07.3224473Z ✔ Fetched commits as d4423d63cd88..77c45f442d9c
2022-07-26T22:38:07.3225044Z --------------------------------------------------------------------------------
2022-07-26T22:38:07.3225667Z [main c2fb53e99b] test: remove test-gc-http-client-timeout from flaky list
2022-07-26T22:38:07.3226055Z Author: Feng Yu F3n67u@outlook.com
2022-07-26T22:38:07.3226366Z Date: Sun Jul 24 22:32:01 2022 +0800
2022-07-26T22:38:07.3226681Z 1 file changed, 2 deletions(-)
2022-07-26T22:38:07.3226987Z ✔ Patches applied
2022-07-26T22:38:07.3227522Z --------------------------------------------------------------------------------
2022-07-26T22:38:07.3228139Z --------------------------------- New Message ----------------------------------
2022-07-26T22:38:07.3228686Z test: remove test-gc-http-client-timeout from flaky list
2022-07-26T22:38:07.3228904Z
2022-07-26T22:38:07.3229199Z PR-URL: https://github.com/nodejs/node/pull/43971
2022-07-26T22:38:07.3229612Z Refs: https://github.com/nodejs/node/pull/43949
2022-07-26T22:38:07.3230075Z Reviewed-By: Tobias Nießen tniessen@tnie.de
2022-07-26T22:38:07.3243488Z Reviewed-By: Luigi Pinca luigipinca@gmail.com
2022-07-26T22:38:07.3243999Z Reviewed-By: Chengzhong Wu legendecas@gmail.com
2022-07-26T22:38:07.3244467Z Reviewed-By: Darshan Sen raisinten@gmail.com
2022-07-26T22:38:07.3245051Z --------------------------------------------------------------------------------
2022-07-26T22:38:07.3245696Z [main a94b0e50e6] test: remove test-gc-http-client-timeout from flaky list
2022-07-26T22:38:07.3246084Z Author: Feng Yu F3n67u@outlook.com
2022-07-26T22:38:07.3246393Z Date: Sun Jul 24 22:32:01 2022 +0800
2022-07-26T22:38:07.3246765Z 1 file changed, 2 deletions(-)
2022-07-26T22:38:07.3247186Z ✔ a94b0e50e685dd0d96308bc213db6d81cb76678b
2022-07-26T22:38:07.3247710Z ✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
2022-07-26T22:38:07.3248222Z ✔ 0:0 skipping fixes-url fixes-url
2022-07-26T22:38:07.3248708Z ✔ 0:0 blank line after title line-after-title
2022-07-26T22:38:07.3249193Z ✔ 0:0 line-lengths are valid line-length
2022-07-26T22:38:07.3249673Z ✔ 0:0 metadata is at end of message metadata-end
2022-07-26T22:38:07.3250139Z ✔ 1:8 PR-URL is valid. pr-url
2022-07-26T22:38:07.3250798Z ✔ 0:0 reviewers are valid reviewers
2022-07-26T22:38:07.3251249Z ✔ 0:0 valid subsystems subsystem
2022-07-26T22:38:07.3251718Z ✔ 0:0 Title is formatted correctly. title-format
2022-07-26T22:38:07.3252203Z ⚠ 0:50 Title should be <= 50 columns. title-length
2022-07-26T22:38:07.3252790Z --------------------------------------------------------------------------------
2022-07-26T22:38:07.3253271Z The following commits are ready to be pushed to origin/main
2022-07-26T22:38:07.3253844Z - a94b0e50e6 test: remove test-gc-http-client-timeout from flaky list
2022-07-26T22:38:07.3254533Z --------------------------------------------------------------------------------
2022-07-26T22:38:07.3254906Z Temporary files removed.
2022-07-26T22:38:07.3255175Z To finish landing:
2022-07-26T22:38:07.3255407Z 1. Run:
2022-07-26T22:38:07.3255639Z git push origin main
2022-07-26T22:38:07.3256089Z 2. Post "Landed in a94b0e50e685" in https://github.com/nodejs/node/pull/43971
2022-07-26T22:38:07.3256600Z gh pr comment 43971 --body "Landed in a94b0e50e685"
2022-07-26T22:38:07.3256890Z gh pr close 43971
2022-07-26T22:38:07.3257792Z + commit_title=test: remove test-gc-http-client-timeout from flaky list
2022-07-26T22:38:07.3258356Z + git log -1 --pretty=format:%b
2022-07-26T22:38:07.3258946Z + commit_body=PR-URL: https://github.com/nodejs/node/pull/43971
2022-07-26T22:38:07.3259479Z Refs: https://github.com/nodejs/node/pull/43949
2022-07-26T22:38:07.3260040Z Reviewed-By: Tobias Nießen tniessen@tnie.de
2022-07-26T22:38:07.3260595Z Reviewed-By: Luigi Pinca luigipinca@gmail.com
2022-07-26T22:38:07.3261156Z Reviewed-By: Chengzhong Wu legendecas@gmail.com
2022-07-26T22:38:07.3261700Z Reviewed-By: Darshan Sen raisinten@gmail.com
2022-07-26T22:38:07.3262140Z + xargs git rev-parse
2022-07-26T22:38:07.3265143Z + grep Fetched commits as output
2022-07-26T22:38:07.3265668Z + cut -d. -f3
2022-07-26T22:38:07.3298799Z + commit_head=77c45f442d9cc23567cfa52543fd521f5b82dd40
2022-07-26T22:38:07.3300204Z + jq -n --arg title test: remove test-gc-http-client-timeout from flaky list --arg body PR-URL: https://github.com/nodejs/node/pull/43971
2022-07-26T22:38:07.3300867Z Refs: https://github.com/nodejs/node/pull/43949
2022-07-26T22:38:07.3301446Z Reviewed-By: Tobias Nießen tniessen@tnie.de
2022-07-26T22:38:07.3301998Z Reviewed-By: Luigi Pinca luigipinca@gmail.com
2022-07-26T22:38:07.3302562Z Reviewed-By: Chengzhong Wu legendecas@gmail.com
2022-07-26T22:38:07.3303541Z Reviewed-By: Darshan Sen raisinten@gmail.com --arg head 77c45f442d9cc23567cfa52543fd521f5b82dd40 {merge_method:"squash",commit_title:$title,commit_message:$body,sha:$head}
2022-07-26T22:38:07.3624010Z + cat output.json
2022-07-26T22:38:07.3632940Z + gh api -X PUT repos/nodejs/node/pulls/43971/merge --input output.json
2022-07-26T22:38:07.3633345Z {
2022-07-26T22:38:07.3633976Z "merge_method": "squash",
2022-07-26T22:38:07.3635132Z "commit_title": "test: remove test-gc-http-client-timeout from flaky list",
2022-07-26T22:38:07.3636499Z "commit_message": "PR-URL: https://github.com/nodejs/node/pull/43971\nRefs: https://github.com/nodejs/node/pull/43949\nReviewed-By: Tobias Nießen tniessen@tnie.de\nReviewed-By: Luigi Pinca luigipinca@gmail.com\nReviewed-By: Chengzhong Wu legendecas@gmail.com\nReviewed-By: Darshan Sen raisinten@gmail.com",
2022-07-26T22:38:07.3637246Z "sha": "77c45f442d9cc23567cfa52543fd521f5b82dd40"
2022-07-26T22:38:07.3637530Z }
2022-07-26T22:38:08.6932996Z + cat output
2022-07-26T22:38:08.6945193Z + jq -r if .merged then .sha else error("not merged") end
2022-07-26T22:38:08.7269401Z + commits=fbcac58db79fc6500d25117535cab1d0643300b3
2022-07-26T22:38:08.7270085Z + rm output.json
2022-07-26T22:38:08.7279958Z + rm output
2022-07-26T22:38:08.7288805Z + gh pr comment 43971 --body Landed in fbcac58db79fc6500d25117535cab1d0643300b3
2022-07-26T22:38:09.4893213Z {"sha":"fbcac58db79fc6500d25117535cab1d0643300b3","merged":true,"message":"Pull Request successfully merged"}https://github.com/nodejs/node/pull/43971#issuecomment-1196049117
2022-07-26T22:38:09.4905596Z + [ -z --oneCommitMax ]
2022-07-26T22:38:09.4906254Z + gh pr view 43921 --json labels --jq .labels
2022-07-26T22:38:09.9635411Z + jq -e map(.name) | index("request-ci")
2022-07-26T22:38:09.9959730Z null
2022-07-26T22:38:09.9964063Z + grep -q \spending\s
2022-07-26T22:38:09.9967649Z + gh pr checks 43921
2022-07-26T22:38:10.4066550Z + gh pr edit 43921 --remove-label commit-queue
2022-07-26T22:38:12.6491971Z https://github.com/nodejs/node/pull/43921
2022-07-26T22:38:12.6505815Z + jq -e map(.name) | index("commit-queue-squash")
2022-07-26T22:38:12.6833642Z 4
2022-07-26T22:38:12.6836513Z + MULTIPLE_COMMIT_POLICY=--fixupAll
2022-07-26T22:38:12.6837780Z + git node land --autorebase --yes --fixupAll 43921
2022-07-26T22:38:15.6844374Z + cat output
2022-07-26T22:38:15.6853744Z - Loading data for nodejs/node/pull/43921
2022-07-26T22:38:15.6854292Z ✔ Done loading data for nodejs/node/pull/43921
2022-07-26T22:38:15.6854886Z ----------------------------------- PR info ------------------------------------
2022-07-26T22:38:15.6855561Z Title deps: cherry-pick 00704f5a from V8 upstream (#43921)
2022-07-26T22:38:15.6856128Z ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
2022-07-26T22:38:15.6856674Z Branch kvakil:backportFasterAccess -> nodejs:main
2022-07-26T22:38:15.6857243Z Labels v8 engine, author ready, needs-ci, commit-queue-squash
2022-07-26T22:38:15.6857559Z Commits 2
2022-07-26T22:38:15.6857939Z - deps: cherry-pick 00704f5a from V8 upstream
2022-07-26T22:38:15.6858283Z - Increment embedder number.
2022-07-26T22:38:15.6858537Z Committers 1
2022-07-26T22:38:15.6858901Z - Keyhan Vakil kvakil@sylph.kvakil.me
2022-07-26T22:38:15.6859381Z PR-URL: https://github.com/nodejs/node/pull/43921
2022-07-26T22:38:15.6859872Z Refs: https://github.com/v8/v8/commit/00704f5a03d9db02c14c4f4c35188effc46e82ab
2022-07-26T22:38:15.6860321Z Refs: https://github.com/nodejs/node/issues/32226
2022-07-26T22:38:15.6860805Z Reviewed-By: Jiawen Geng technicalcute@gmail.com
2022-07-26T22:38:15.6861302Z Reviewed-By: Michaël Zasso targos@protonmail.com
2022-07-26T22:38:15.6861749Z Reviewed-By: Feng Yu F3n67u@outlook.com
2022-07-26T22:38:15.6862318Z ------------------------------ Generated metadata ------------------------------
2022-07-26T22:38:15.6862864Z PR-URL: https://github.com/nodejs/node/pull/43921
2022-07-26T22:38:15.6863356Z Refs: https://github.com/v8/v8/commit/00704f5a03d9db02c14c4f4c35188effc46e82ab
2022-07-26T22:38:15.6863803Z Refs: https://github.com/nodejs/node/issues/32226
2022-07-26T22:38:15.6864280Z Reviewed-By: Jiawen Geng technicalcute@gmail.com
2022-07-26T22:38:15.6864765Z Reviewed-By: Michaël Zasso targos@protonmail.com
2022-07-26T22:38:15.6865207Z Reviewed-By: Feng Yu F3n67u@outlook.com
2022-07-26T22:38:15.6865771Z --------------------------------------------------------------------------------
2022-07-26T22:38:15.6866288Z ℹ This PR was created on Thu, 21 Jul 2022 03:04:59 GMT
2022-07-26T22:38:15.6866612Z ✔ Approvals: 3
2022-07-26T22:38:15.6867178Z ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/43921#pullrequestreview-1045883358
2022-07-26T22:38:15.6867891Z ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/43921#pullrequestreview-1045943395
2022-07-26T22:38:15.6868563Z ✔ - Feng Yu (@F3n67u): https://github.com/nodejs/node/pull/43921#pullrequestreview-1049693633
2022-07-26T22:38:15.6869006Z ✔ Last GitHub CI successful
2022-07-26T22:38:15.6869573Z ℹ Last Full PR CI on 2022-07-25T22:20:34Z: https://ci.nodejs.org/job/node-test-pull-request/45677/
2022-07-26T22:38:15.6870244Z ℹ Last V8 CI on 2022-07-25T19:39:25Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/4787/
2022-07-26T22:38:15.6870808Z - Querying data for job/node-test-pull-request/45677/
2022-07-26T22:38:15.6871209Z ✔ Last Jenkins CI successful
2022-07-26T22:38:15.6872438Z --------------------------------------------------------------------------------
2022-07-26T22:38:15.6876559Z ✔ No git cherry-pick in progress
2022-07-26T22:38:15.6876980Z ✔ No git am in progress
2022-07-26T22:38:15.6877327Z ✔ No git rebase in progress
2022-07-26T22:38:15.6877878Z --------------------------------------------------------------------------------
2022-07-26T22:38:15.6878344Z - Bringing origin/main up to date...
2022-07-26T22:38:15.6878700Z From https://github.com/nodejs/node
2022-07-26T22:38:15.6879115Z branch main -> FETCH_HEAD
2022-07-26T22:38:15.6879537Z d4423d63cd..fbcac58db7 main -> origin/main
2022-07-26T22:38:15.6879930Z ✔ origin/main is now up-to-date
2022-07-26T22:38:15.6880477Z main is out of sync with origin/main. Mismatched commits:
2022-07-26T22:38:15.6881009Z - a94b0e50e6 test: remove test-gc-http-client-timeout from flaky list
2022-07-26T22:38:15.6881555Z - fbcac58db7 test: remove test-gc-http-client-timeout from flaky list
2022-07-26T22:38:15.6882185Z --------------------------------------------------------------------------------
2022-07-26T22:38:15.6882829Z HEAD is now at fbcac58db7 test: remove test-gc-http-client-timeout from flaky list
2022-07-26T22:38:15.6883236Z ✔ Reset to origin/main
2022-07-26T22:38:15.6883580Z - Downloading patch for 43921
2022-07-26T22:38:15.6883922Z From https://github.com/nodejs/node
2022-07-26T22:38:15.6884365Z branch refs/pull/43921/merge -> FETCH_HEAD
2022-07-26T22:38:15.6884831Z ✔ Fetched commits as fbcac58db79f..beed8355942c
2022-07-26T22:38:15.6889743Z --------------------------------------------------------------------------------
2022-07-26T22:38:15.6890400Z [main 87d1c68189] deps: cherry-pick 00704f5a from V8 upstream
2022-07-26T22:38:15.6890795Z Author: Keyhan Vakil kvakil@sylph.kvakil.me
2022-07-26T22:38:15.6891117Z Date: Thu Jul 21 03:01:43 2022 +0000
2022-07-26T22:38:15.6891476Z 3 files changed, 26 insertions(+), 1 deletion(-)
2022-07-26T22:38:15.6891856Z [main 07f68454b5] Increment embedder number.
2022-07-26T22:38:15.6892211Z Author: Keyhan Vakil kvakil@sylph.kvakil.me
2022-07-26T22:38:15.6892524Z Date: Thu Jul 21 04:46:04 2022 +0000
2022-07-26T22:38:15.6892878Z 1 file changed, 1 insertion(+), 1 deletion(-)
2022-07-26T22:38:15.6893207Z ✔ Patches applied
2022-07-26T22:38:15.6893649Z There are 2 commits in the PR. Attempting to fixup everything into first commit.
2022-07-26T22:38:15.6894206Z [main 179d976603] deps: cherry-pick 00704f5a from V8 upstream
2022-07-26T22:38:15.6894571Z Author: Keyhan Vakil kvakil@sylph.kvakil.me
2022-07-26T22:38:15.6894883Z Date: Thu Jul 21 03:01:43 2022 +0000
2022-07-26T22:38:15.6895228Z 4 files changed, 27 insertions(+), 2 deletions(-)
2022-07-26T22:38:15.6895828Z ⚠ Found Refs: https://github.com/v8/v8/commit/00704f5a03d9db02c14c4f4c35188effc46e82ab, skipping..
2022-07-26T22:38:15.6896403Z ⚠ Found Refs: https://github.com/nodejs/node/issues/32226, skipping..
2022-07-26T22:38:15.6897012Z --------------------------------- New Message ----------------------------------
2022-07-26T22:38:15.6897536Z deps: cherry-pick 00704f5a from V8 upstream
2022-07-26T22:38:15.6897723Z
2022-07-26T22:38:15.6897854Z Original commit message:
2022-07-26T22:38:15.6898011Z
2022-07-26T22:38:15.6898222Z Add more efficient API for accesssing ArrayBuffer raw data
2022-07-26T22:38:15.6898431Z
2022-07-26T22:38:15.6898747Z Raw data access is already possible via GetBackingStore()->GetData().
2022-07-26T22:38:15.6899156Z This API exposes a more efficient way for accessing
2022-07-26T22:38:15.6899606Z JSArrayBuffer::backing_store (which, despite the confusing name, is no
2022-07-26T22:38:15.6899996Z the BackingStore but its raw data pointer).
2022-07-26T22:38:15.6900180Z
2022-07-26T22:38:15.6900279Z Bug: v8:10343
2022-07-26T22:38:15.6900700Z Change-Id: I695cea91e2c3de75ce6c86bac6e413ce6617958b
2022-07-26T22:38:15.6901260Z Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764341
2022-07-26T22:38:15.6901928Z Reviewed-by: Camillo Bruni cbruni@chromium.org
2022-07-26T22:38:15.6902377Z Commit-Queue: Marja Hölttä marja@chromium.org
2022-07-26T22:38:15.6902815Z Cr-Commit-Position: refs/heads/main@{#81745}
2022-07-26T22:38:15.6903009Z
2022-07-26T22:38:15.6903311Z Refs: https://github.com/v8/v8/commit/00704f5a03d9db02c14c4f4c35188effc46e82ab
2022-07-26T22:38:15.6903768Z Refs: https://github.com/nodejs/node/issues/32226
2022-07-26T22:38:15.6903965Z
2022-07-26T22:38:15.6904257Z PR-URL: https://github.com/nodejs/node/pull/43921
2022-07-26T22:38:15.6904744Z Reviewed-By: Jiawen Geng technicalcute@gmail.com
2022-07-26T22:38:15.6905233Z Reviewed-By: Michaël Zasso targos@protonmail.com
2022-07-26T22:38:15.6905674Z Reviewed-By: Feng Yu F3n67u@outlook.com
2022-07-26T22:38:15.6906308Z --------------------------------------------------------------------------------
2022-07-26T22:38:15.6906881Z [main ee888ad3b3] deps: cherry-pick 00704f5a from V8 upstream
2022-07-26T22:38:15.6907255Z Author: Keyhan Vakil kvakil@sylph.kvakil.me
2022-07-26T22:38:15.6907578Z Date: Thu Jul 21 03:01:43 2022 +0000
2022-07-26T22:38:15.6907938Z 4 files changed, 27 insertions(+), 2 deletions(-)
2022-07-26T22:38:15.6911433Z ✔ ee888ad3b329e9026c62c77d7f3801593dd999c7
2022-07-26T22:38:15.6912154Z ✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
2022-07-26T22:38:15.6912677Z ✔ 0:0 skipping fixes-url fixes-url
2022-07-26T22:38:15.6913168Z ✔ 0:0 blank line after title line-after-title
2022-07-26T22:38:15.6913652Z ✔ 0:0 line-lengths are valid line-length
2022-07-26T22:38:15.6914137Z ✔ 0:0 metadata is at end of message metadata-end
2022-07-26T22:38:15.6914608Z ✔ 20:8 PR-URL is valid. pr-url
2022-07-26T22:38:15.6915057Z ✔ 0:0 reviewers are valid reviewers
2022-07-26T22:38:15.6915508Z ✔ 0:0 valid subsystems subsystem
2022-07-26T22:38:15.6915983Z ✔ 0:0 Title is formatted correctly. title-format
2022-07-26T22:38:15.6916451Z ✔ 0:0 Title is <= 50 columns. title-length
2022-07-26T22:38:15.6917029Z --------------------------------------------------------------------------------
2022-07-26T22:38:15.6917531Z The following commits are ready to be pushed to origin/main
2022-07-26T22:38:15.6918041Z - ee888ad3b3 deps: cherry-pick 00704f5a from V8 upstream
2022-07-26T22:38:15.6918620Z --------------------------------------------------------------------------------
2022-07-26T22:38:15.6918982Z Temporary files removed.
2022-07-26T22:38:15.6919248Z To finish landing:
2022-07-26T22:38:15.6919476Z 1. Run:
2022-07-26T22:38:15.6919718Z git push origin main
2022-07-26T22:38:15.6920164Z 2. Post "Landed in ee888ad3b329" in https://github.com/nodejs/node/pull/43921
2022-07-26T22:38:15.6920662Z gh pr comment 43921 --body "Landed in ee888ad3b329"
2022-07-26T22:38:15.6920952Z gh pr close 43921
2022-07-26T22:38:15.6921422Z + grep -q . Post "Landed in ./pull/43921 output
2022-07-26T22:38:15.6921760Z + [ -z --fixupAll ]
2022-07-26T22:38:15.6922123Z + git log -1 --pretty=format:%s
2022-07-26T22:38:15.6922602Z + commit_title=deps: cherry-pick 00704f5a from V8 upstream
2022-07-26T22:38:15.6923010Z + git log -1 --pretty=format:%b
2022-07-26T22:38:15.6936453Z + commit_body=Original commit message:
2022-07-26T22:38:15.6936670Z
2022-07-26T22:38:15.6936888Z Add more efficient API for accesssing ArrayBuffer raw data
2022-07-26T22:38:15.6937101Z
2022-07-26T22:38:15.6937495Z Raw data access is already possible via GetBackingStore()->GetData().
2022-07-26T22:38:15.6937912Z This API exposes a more efficient way for accessing
2022-07-26T22:38:15.6938368Z JSArrayBuffer::backing_store (which, despite the confusing name, is no
2022-07-26T22:38:15.6938765Z the BackingStore but its raw data pointer).
2022-07-26T22:38:15.6938954Z
2022-07-26T22:38:15.6939232Z Bug: v8:10343
2022-07-26T22:38:15.6939671Z Change-Id: I695cea91e2c3de75ce6c86bac6e413ce6617958b
2022-07-26T22:38:15.6940235Z Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764341
2022-07-26T22:38:15.6940750Z Reviewed-by: Camillo Bruni cbruni@chromium.org
2022-07-26T22:38:15.6941206Z Commit-Queue: Marja Hölttä marja@chromium.org
2022-07-26T22:38:15.6943658Z Cr-Commit-Position: refs/heads/main@{#81745}
2022-07-26T22:38:15.6943857Z
2022-07-26T22:38:15.6944160Z Refs: https://github.com/v8/v8/commit/00704f5a03d9db02c14c4f4c35188effc46e82ab
2022-07-26T22:38:15.6944617Z Refs: https://github.com/nodejs/node/issues/32226
2022-07-26T22:38:15.6944813Z
2022-07-26T22:38:15.6945106Z PR-URL: https://github.com/nodejs/node/pull/43921
2022-07-26T22:38:15.6945676Z Reviewed-By: Jiawen Geng technicalcute@gmail.com
2022-07-26T22:38:15.6946175Z Reviewed-By: Michaël Zasso targos@protonmail.com
2022-07-26T22:38:15.6946623Z Reviewed-By: Feng Yu F3n67u@outlook.com
2022-07-26T22:38:15.6946938Z + cut -d. -f3
2022-07-26T22:38:15.6947246Z + grep Fetched commits as output
2022-07-26T22:38:15.6950876Z + xargs git rev-parse
2022-07-26T22:38:15.6981176Z + commit_head=beed8355942c59dc54eb7bb4bc8a83733457b49c
2022-07-26T22:38:15.6982003Z + jq -n --arg title deps: cherry-pick 00704f5a from V8 upstream --arg body Original commit message:
2022-07-26T22:38:15.6982282Z
2022-07-26T22:38:15.6982503Z Add more efficient API for accesssing ArrayBuffer raw data
2022-07-26T22:38:15.6982741Z
2022-07-26T22:38:15.6983071Z Raw data access is already possible via GetBackingStore()->GetData().
2022-07-26T22:38:15.6983490Z This API exposes a more efficient way for accessing
2022-07-26T22:38:15.6983956Z JSArrayBuffer::backing_store (which, despite the confusing name, is no
2022-07-26T22:38:15.6984343Z the BackingStore but its raw data pointer).
2022-07-26T22:38:15.6984550Z
2022-07-26T22:38:15.6984635Z Bug: v8:10343
2022-07-26T22:38:15.6985067Z Change-Id: I695cea91e2c3de75ce6c86bac6e413ce6617958b
2022-07-26T22:38:15.6985644Z Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764341
2022-07-26T22:38:15.6986156Z Reviewed-by: Camillo Bruni cbruni@chromium.org
2022-07-26T22:38:15.6986620Z Commit-Queue: Marja Hölttä marja@chromium.org
2022-07-26T22:38:15.6987059Z Cr-Commit-Position: refs/heads/main@{#81745}
2022-07-26T22:38:15.6987253Z
2022-07-26T22:38:15.6987553Z Refs: https://github.com/v8/v8/commit/00704f5a03d9db02c14c4f4c35188effc46e82ab
2022-07-26T22:38:15.6988008Z Refs: https://github.com/nodejs/node/issues/32226
2022-07-26T22:38:15.6988204Z
2022-07-26T22:38:15.6988510Z PR-URL: https://github.com/nodejs/node/pull/43921
2022-07-26T22:38:15.6988993Z Reviewed-By: Jiawen Geng technicalcute@gmail.com
2022-07-26T22:38:15.6989486Z Reviewed-By: Michaël Zasso targos@protonmail.com
2022-07-26T22:38:15.6990380Z Reviewed-By: Feng Yu F3n67u@outlook.com --arg head beed8355942c59dc54eb7bb4bc8a83733457b49c {merge_method:"squash",commit_title:$title,commit_message:$body,sha:$head}
2022-07-26T22:38:15.7296617Z + cat output.json
2022-07-26T22:38:15.7302701Z {
2022-07-26T22:38:15.7305317Z + gh api -X PUT repos/nodejs/node/pulls/43921/merge --input output.json
2022-07-26T22:38:15.7305741Z "merge_method": "squash",
2022-07-26T22:38:15.7306594Z "commit_title": "deps: cherry-pick 00704f5a from V8 upstream",
2022-07-26T22:38:15.7311060Z "commit_message": "Original commit message:\n\n Add more efficient API for accesssing ArrayBuffer raw data\n\n Raw data access is already possible via GetBackingStore()->GetData().\n This API exposes a more efficient way for accessing\n JSArrayBuffer::backing_store (which, despite the confusing name, is no\n the BackingStore but its raw data pointer).\n\n Bug: v8:10343\n Change-Id: I695cea91e2c3de75ce6c86bac6e413ce6617958b\n Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3764341\n Reviewed-by: Camillo Bruni cbruni@chromium.org\n Commit-Queue: Marja Hölttä marja@chromium.org\n Cr-Commit-Position: refs/heads/main@{#81745}\n\nRefs: https://github.com/v8/v8/commit/00704f5a03d9db02c14c4f4c35188effc46e82ab\nRefs: https://github.com/nodejs/node/issues/32226\n\nPR-URL: https://github.com/nodejs/node/pull/43921\nReviewed-By: Jiawen Geng technicalcute@gmail.com\nReviewed-By: Michaël Zasso targos@protonmail.com\nReviewed-By: Feng Yu F3n67u@outlook.com",
2022-07-26T22:38:15.7314104Z "sha": "beed8355942c59dc54eb7bb4bc8a83733457b49c"
2022-07-26T22:38:15.7314623Z }
2022-07-26T22:38:16.9526526Z + cat output
2022-07-26T22:38:16.9538575Z + jq -r if .merged then .sha else error("not merged") end
2022-07-26T22:38:16.9859648Z + commits=9916ef813b64587f89bb7e96e313aa8fff536787
2022-07-26T22:38:16.9860204Z + rm output.json
2022-07-26T22:38:16.9869656Z + rm output
2022-07-26T22:38:16.9880625Z + gh pr comment 43921 --body Landed in 9916ef813b64587f89bb7e96e313aa8fff536787
2022-07-26T22:38:17.7694256Z {"sha":"9916ef813b64587f89bb7e96e313aa8fff536787","merged":true,"message":"Pull Request successfully merged"}https://github.com/nodejs/node/pull/43921#issuecomment-1196049228
2022-07-26T22:38:17.7707180Z + [ -z --fixupAll ]
2022-07-26T22:38:17.7708131Z + gh pr view 43849 --json labels --jq .labels
2022-07-26T22:38:18.0760155Z + jq -e map(.name) | index("request-ci")
2022-07-26T22:38:18.1076349Z null
2022-07-26T22:38:18.1081759Z + gh pr checks 43849
2022-07-26T22:38:18.1082497Z + grep -q \spending\s
2022-07-26T22:38:18.5337732Z + gh pr edit 43849 --remove-label commit-queue
2022-07-26T22:38:20.8578676Z https://github.com/nodejs/node/pull/43849
2022-07-26T22:38:20.8594018Z + jq -e map(.name) | index("commit-queue-squash")
2022-07-26T22:38:20.8923199Z 4
2022-07-26T22:38:20.8925897Z + MULTIPLE_COMMIT_POLICY=--fixupAll
2022-07-26T22:38:20.8926564Z + git node land --autorebase --yes --fixupAll 43849
2022-07-26T22:38:24.0244012Z + cat output
2022-07-26T22:38:24.0251250Z - Loading data for nodejs/node/pull/43849
2022-07-26T22:38:24.0252095Z ✔ Done loading data for nodejs/node/pull/43849
2022-07-26T22:38:24.0252898Z + grep -q . Post "Landed in ./pull/43849 output
2022-07-26T22:38:24.0253633Z ----------------------------------- PR info ------------------------------------
2022-07-26T22:38:24.0255297Z Title lib: add Promise
methods to avoid-prototype-pollution
lint rule (#43849)
2022-07-26T22:38:24.0256139Z ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
2022-07-26T22:38:24.0266794Z + [ -z --fixupAll ]
2022-07-26T22:38:24.0267496Z Branch aduh95:lint-unsafe-promise-methods -> nodejs:main
2022-07-26T22:38:24.0268442Z Labels lib / src, author ready, needs-ci, commit-queue-squash
2022-07-26T22:38:24.0268962Z Commits 2
2022-07-26T22:38:24.0269611Z - lib: add Promise
methods to avoid-prototype-pollution
lint rule
2022-07-26T22:38:24.0333432Z + git log -1 --pretty=format:%s
2022-07-26T22:38:24.0356458Z - Update test-primordials-promise.js
2022-07-26T22:38:24.0357346Z + commit_title=lib: add Promise
methods to avoid-prototype-pollution
lint rule
2022-07-26T22:38:24.0357842Z + git log -1 --pretty=format:%b
2022-07-26T22:38:24.0358102Z Committers 2
2022-07-26T22:38:24.0358515Z - Antoine du Hamel duhamelantoine1995@gmail.com
2022-07-26T22:38:24.0358889Z - GitHub noreply@github.com
2022-07-26T22:38:24.0359344Z PR-URL: https://github.com/nodejs/node/pull/43849
2022-07-26T22:38:24.0359843Z Reviewed-By: Matteo Collina matteo.collina@gmail.com
2022-07-26T22:38:24.0360314Z Reviewed-By: Paolo Insogna paolo@cowtech.it
2022-07-26T22:38:24.0360894Z ------------------------------ Generated metadata ------------------------------
2022-07-26T22:38:24.0361424Z PR-URL: https://github.com/nodejs/node/pull/43849
2022-07-26T22:38:24.0361919Z Reviewed-By: Matteo Collina matteo.collina@gmail.com
2022-07-26T22:38:24.0362391Z Reviewed-By: Paolo Insogna paolo@cowtech.it
2022-07-26T22:38:24.0362957Z --------------------------------------------------------------------------------
2022-07-26T22:38:24.0363474Z ℹ This PR was created on Fri, 15 Jul 2022 16:40:26 GMT
2022-07-26T22:38:24.0364052Z ✔ Approvals: 2
2022-07-26T22:38:24.0364686Z ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43849#pullrequestreview-1041640124
2022-07-26T22:38:24.0365387Z ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/43849#pullrequestreview-1041746513
2022-07-26T22:38:24.0365845Z ✔ Last GitHub CI successful
2022-07-26T22:38:24.0366411Z ℹ Last Full PR CI on 2022-07-26T17:52:20Z: https://ci.nodejs.org/job/node-test-pull-request/45692/
2022-07-26T22:38:24.0366977Z - Querying data for job/node-test-pull-request/45692/
2022-07-26T22:38:24.0367370Z ✔ Last Jenkins CI successful
2022-07-26T22:38:24.0367912Z --------------------------------------------------------------------------------
2022-07-26T22:38:24.0368428Z ✔ No git cherry-pick in progress
2022-07-26T22:38:24.0368762Z ✔ No git am in progress
2022-07-26T22:38:24.0369087Z ✔ No git rebase in progress
2022-07-26T22:38:24.0369617Z --------------------------------------------------------------------------------
2022-07-26T22:38:24.0370079Z - Bringing origin/main up to date...
2022-07-26T22:38:24.0370430Z From https://github.com/nodejs/node
2022-07-26T22:38:24.0370833Z branch main -> FETCH_HEAD
2022-07-26T22:38:24.0371247Z fbcac58db7..9916ef813b main -> origin/main
2022-07-26T22:38:24.0371632Z ✔ origin/main is now up-to-date
2022-07-26T22:38:24.0372024Z main is out of sync with origin/main. Mismatched commits:
2022-07-26T22:38:24.0372480Z - ee888ad3b3 deps: cherry-pick 00704f5a from V8 upstream
2022-07-26T22:38:24.0372919Z - 9916ef813b deps: cherry-pick 00704f5a from V8 upstream
2022-07-26T22:38:24.0373479Z --------------------------------------------------------------------------------
2022-07-26T22:38:24.0374054Z HEAD is now at 9916ef813b deps: cherry-pick 00704f5a from V8 upstream
2022-07-26T22:38:24.0374414Z ✔ Reset to origin/main
2022-07-26T22:38:24.0374744Z - Downloading patch for 43849
2022-07-26T22:38:24.0375074Z From https://github.com/nodejs/node
2022-07-26T22:38:24.0375521Z branch refs/pull/43849/merge -> FETCH_HEAD
2022-07-26T22:38:24.0375971Z ✔ Fetched commits as 9916ef813b64..f4c5d9a6be45
2022-07-26T22:38:24.0376521Z --------------------------------------------------------------------------------
2022-07-26T22:38:24.0377021Z Auto-merging lib/internal/main/worker_thread.js
2022-07-26T22:38:24.0377507Z Auto-merging lib/internal/webstreams/readablestream.js
2022-07-26T22:38:24.0378121Z [main 49ba9d6b61] lib: add Promise
methods to avoid-prototype-pollution
lint rule
2022-07-26T22:38:24.0378566Z Author: Antoine du Hamel duhamelantoine1995@gmail.com
2022-07-26T22:38:24.0378892Z Date: Fri Jul 15 18:23:44 2022 +0200
2022-07-26T22:38:24.0379253Z 9 files changed, 83 insertions(+), 35 deletions(-)
2022-07-26T22:38:24.0379727Z [main 792c7e2593] Update test-primordials-promise.js
2022-07-26T22:38:24.0380108Z Author: Antoine du Hamel duhamelantoine1995@gmail.com
2022-07-26T22:38:24.0380422Z Date: Tue Jul 26 19:40:21 2022 +0200
2022-07-26T22:38:24.0383287Z 1 file changed, 8 insertions(+), 10 deletions(-)
2022-07-26T22:38:24.0383616Z ✔ Patches applied
2022-07-26T22:38:24.0384054Z There are 2 commits in the PR. Attempting to fixup everything into first commit.
2022-07-26T22:38:24.0384711Z [main 4bcd50ab01] lib: add Promise
methods to avoid-prototype-pollution
lint rule
2022-07-26T22:38:24.0385166Z Author: Antoine du Hamel duhamelantoine1995@gmail.com
2022-07-26T22:38:24.0385494Z Date: Fri Jul 15 18:23:44 2022 +0200
2022-07-26T22:38:24.0385849Z 10 files changed, 91 insertions(+), 45 deletions(-)
2022-07-26T22:38:24.0386419Z --------------------------------- New Message ----------------------------------
2022-07-26T22:38:24.0387016Z lib: add Promise
methods to avoid-prototype-pollution
lint rule
2022-07-26T22:38:24.0387251Z
2022-07-26T22:38:24.0387544Z PR-URL: https://github.com/nodejs/node/pull/43849
2022-07-26T22:38:24.0388038Z Reviewed-By: Matteo Collina matteo.collina@gmail.com
2022-07-26T22:38:24.0388619Z Reviewed-By: Paolo Insogna paolo@cowtech.it
2022-07-26T22:38:24.0389189Z --------------------------------------------------------------------------------
2022-07-26T22:38:24.0389829Z [main fc9fd30f95] lib: add Promise
methods to avoid-prototype-pollution
lint rule
2022-07-26T22:38:24.0390271Z Author: Antoine du Hamel duhamelantoine1995@gmail.com
2022-07-26T22:38:24.0390601Z Date: Fri Jul 15 18:23:44 2022 +0200
2022-07-26T22:38:24.0393391Z 10 files changed, 91 insertions(+), 45 deletions(-)
2022-07-26T22:38:24.0393837Z ✔ fc9fd30f957d3f88fcd881004f10eff455c70b0b
2022-07-26T22:38:24.0394356Z ✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
2022-07-26T22:38:24.0394970Z ✔ 0:0 skipping fixes-url fixes-url
2022-07-26T22:38:24.0395464Z ✔ 0:0 blank line after title line-after-title
2022-07-26T22:38:24.0395938Z ✔ 0:0 line-lengths are valid line-length
2022-07-26T22:38:24.0396416Z ✔ 0:0 metadata is at end of message metadata-end
2022-07-26T22:38:24.0396876Z ✔ 1:8 PR-URL is valid. pr-url
2022-07-26T22:38:24.0397346Z ✔ 0:0 reviewers are valid reviewers
2022-07-26T22:38:24.0397793Z ✔ 0:0 valid subsystems subsystem
2022-07-26T22:38:24.0398251Z ✔ 0:0 Title is formatted correctly. title-format
2022-07-26T22:38:24.0398731Z ⚠ 0:50 Title should be <= 50 columns. title-length
2022-07-26T22:38:24.0399308Z --------------------------------------------------------------------------------
2022-07-26T22:38:24.0399777Z The following commits are ready to be pushed to origin/main
2022-07-26T22:38:24.0400378Z - fc9fd30f95 lib: add Promise
methods to avoid-prototype-pollution
lint rule
2022-07-26T22:38:24.0400997Z --------------------------------------------------------------------------------
2022-07-26T22:38:24.0401354Z Temporary files removed.
2022-07-26T22:38:24.0401614Z To finish landing:
2022-07-26T22:38:24.0401839Z 1. Run:
2022-07-26T22:38:24.0402072Z git push origin main
2022-07-26T22:38:24.0402508Z 2. Post "Landed in fc9fd30f957d" in https://github.com/nodejs/node/pull/43849
2022-07-26T22:38:24.0402999Z gh pr comment 43849 --body "Landed in fc9fd30f957d"
2022-07-26T22:38:24.0403280Z gh pr close 43849
2022-07-26T22:38:24.0403794Z + commit_body=PR-URL: https://github.com/nodejs/node/pull/43849
2022-07-26T22:38:24.0404313Z Reviewed-By: Matteo Collina matteo.collina@gmail.com
2022-07-26T22:38:24.0404782Z Reviewed-By: Paolo Insogna paolo@cowtech.it
2022-07-26T22:38:24.0405099Z + cut -d. -f3
2022-07-26T22:38:24.0405400Z + grep Fetched commits as output
2022-07-26T22:38:24.0405729Z + xargs git rev-parse
2022-07-26T22:38:24.0421814Z + commit_head=f4c5d9a6be4516fd815a8e107d526a17c03a5b43
2022-07-26T22:38:24.0422756Z + jq -n --arg title lib: add Promise
methods to avoid-prototype-pollution
lint rule --arg body PR-URL: https://github.com/nodejs/node/pull/43849
2022-07-26T22:38:24.0423423Z Reviewed-By: Matteo Collina matteo.collina@gmail.com
2022-07-26T22:38:24.0424331Z Reviewed-By: Paolo Insogna paolo@cowtech.it --arg head f4c5d9a6be4516fd815a8e107d526a17c03a5b43 {merge_method:"squash",commit_title:$title,commit_message:$body,sha:$head}
2022-07-26T22:38:24.0737754Z + cat output.json
2022-07-26T22:38:24.0745464Z + gh api -X PUT repos/nodejs/node/pulls/43849/merge --input output.json
2022-07-26T22:38:24.0745859Z {
2022-07-26T22:38:24.0746459Z "merge_method": "squash",
2022-07-26T22:38:24.0747317Z "commit_title": "lib: add Promise
methods to avoid-prototype-pollution
lint rule",
2022-07-26T22:38:24.0748893Z "commit_message": "PR-URL: https://github.com/nodejs/node/pull/43849\nReviewed-By: Matteo Collina matteo.collina@gmail.com\nReviewed-By: Paolo Insogna paolo@cowtech.it",
2022-07-26T22:38:24.0749718Z "sha": "f4c5d9a6be4516fd815a8e107d526a17c03a5b43"
2022-07-26T22:38:24.0750432Z }
2022-07-26T22:38:25.4773700Z + cat output
2022-07-26T22:38:25.4787787Z + jq -r if .merged then .sha else error("not merged") end
2022-07-26T22:38:25.5108685Z + commits=d7f193434ab699297814879835846cd4440e25ee
2022-07-26T22:38:25.5109607Z + rm output.json
2022-07-26T22:38:25.5120380Z + rm output
2022-07-26T22:38:25.5129661Z + gh pr comment 43849 --body Landed in d7f193434ab699297814879835846cd4440e25ee
2022-07-26T22:38:26.2668836Z {"sha":"d7f193434ab699297814879835846cd4440e25ee","merged":true,"message":"Pull Request successfully merged"}https://github.com/nodejs/node/pull/43849#issuecomment-1196049318
2022-07-26T22:38:26.2679218Z + [ -z --fixupAll ]
2022-07-26T22:38:26.2679996Z + rm -f labels.json
2022-07-26T22:38:26.2733355Z Post job cleanup.
2022-07-26T22:38:26.4352421Z Post job cleanup.
2022-07-26T22:38:26.5588170Z [command]/usr/bin/git version
2022-07-26T22:38:26.5639098Z git version 2.37.1
2022-07-26T22:38:26.5683981Z Temporarily overriding HOME='/home/runner/work/_temp/5d07ca96-dd12-4d01-bd4c-85ec9bab7595' before making global git config changes
2022-07-26T22:38:26.5684970Z Adding repository directory to the temporary git global config as a safe directory
2022-07-26T22:38:26.5689797Z [command]/usr/bin/git config --global --add safe.directory /home/runner/work/node/node
2022-07-26T22:38:26.5731430Z [command]/usr/bin/git config --local --name-only --get-regexp core.sshCommand
2022-07-26T22:38:26.5768882Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2022-07-26T22:38:26.6050798Z [command]/usr/bin/git config --local --name-only --get-regexp http.https\:\/\/github.com\/.extraheader
2022-07-26T22:38:26.6079435Z http.https://github.com/.extraheader
2022-07-26T22:38:26.6090297Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
2022-07-26T22:38:26.6127319Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'http.https\:\/\/github.com\/.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :
2022-07-26T22:38:26.6696438Z Cleaning up orphan processes
</details>
The CQ landed https://github.com/nodejs/node/pull/43849, even though I pushed a commit way after the last review. I'm not what caused this, but it shouldn't have happened – the only "unusual" thing I've done was using the web UI to create the last commit, perhaps those are somehow missed?
Originally posted by @nodejs-github-bot in https://github.com/nodejs/node/issues/43849#issuecomment-1196049318