Open gengjiawen opened 1 year ago
It's not a false positive. I rebased and pushed after the last review.
I just retriggered commit-queue, still failed.
Yes, but that's expected. Someone needs to submit a review after the push.
Yes, but that's expected. Someone needs to submit a review after the push.
I approved the PR again, new commit-queue
still failed.
Isn't it because of this?
Nope, it's a bug in GitHub (not sure how long they can fix it, it's has been really long), there is a issue on it too IIRC.
You can see log here, it shows it's the github action fails.
I reopened because the error was wrong, but I still think the failure was expected (Jenkins CI had a failure).
Yeah, "GitHub CI" is not very accurate because all it does is check the "status of the PR", which includes the Jenkins results (which are sometimes picked up from a run that's testing an older commit, but that's really not something that can be addressed in this repo).
But why did ncu say "Last Jenkins CI successful" when https://ci.nodejs.org/job/node-test-pull-request/48124/ is clearly red?
Another one: https://github.com/nodejs/node-core-utils/issues/691
I had a look and it's because of this part of the code: https://github.com/nodejs/node-core-utils/blob/4ef0fe2607f3986f702bcd1ada244965cfcd4457/lib/pr_checker.js#L393-L410
It's actually the Jenkins CI check that is red. I wonder if we should remove this whole block. I don't know what kind of "old" checks we expect to be here.
Commit Queue failed
https://github.com/nodejs/node/actions/runs/3538908052Originally posted by @nodejs-github-bot in https://github.com/nodejs/node/issues/45573#issuecomment-1326111158