nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
227 stars 105 forks source link

Unhelpful error message when using unknown remote #701

Open anonrig opened 10 months ago

anonrig commented 10 months ago

I'm receiving a weird error running the following command:

git node land 48272
Error: git config,--get,remote.remote-upstream.url failed with stderr:
    at runSync (file:///Users/yagiz/.volta/tools/image/packages/node-core-utils/lib/node_modules/node-core-utils/lib/run.js:91:11)
    at new Session (file:///Users/yagiz/.volta/tools/image/packages/node-core-utils/lib/node_modules/node-core-utils/lib/session.js:30:26)
    at new LandingSession (file:///Users/yagiz/.volta/tools/image/packages/node-core-utils/lib/node_modules/node-core-utils/lib/landing_session.js:28:5)
    at main (file:///Users/yagiz/.volta/tools/image/packages/node-core-utils/lib/node_modules/node-core-utils/components/git/land.js:167:17)
aduh95 commented 10 months ago

Can you paste the result of cat .git/config please?

anonrig commented 10 months ago
cat .git/config
[core]
    repositoryformatversion = 0
    filemode = true
    bare = false
    logallrefupdates = true
    ignorecase = true
    precomposeunicode = true
[remote "origin"]
    url = git@github.com:anonrig/node.git
    fetch = +refs/heads/*:refs/remotes/origin/*
aduh95 commented 10 months ago

You don't have a remote called remote-upstream, so ncu cannot read the URL associated with it. To fix the issue, you need to either create a remote remote-upstream, or change the .ncu/config file to use a different remote name (likely upstream).

anonrig commented 10 months ago

Ah, you're right. I've setup the NCU incorrectly. Thank you @aduh95

aduh95 commented 10 months ago

We could still decide to change the default to be upstream rather than remote-upstream and/or improve the error message when the git config call fails to hint into what might be wrong.

anonrig commented 10 months ago

Definitely, that might be helpful, for cases like this.