search

nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
234 stars 106 forks source link

feat(git-node): add support for `amend!` commits #710

Closed aduh95 closed 10 months ago

aduh95 commented 10 months ago

Commits made using git commit --fixup=reword:HEAD are empty commits that lets the user change the commit message without needing to force-push the PR branch. With this commit, those are still ignored when using --fixupAll CLI flag.

Another change with this PR is that ncu will no longer reject PRs with empty commits, but will drop them from the rebase. Previously, empty commits were allowed only when using --fixupAll.

Tested locally with https://github.com/nodejs/node/pull/48513.

codecov[bot] commented 10 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (015bf20) 83.38% compared to head (91e7cad) 83.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #710 +/- ## ======================================= Coverage 83.38% 83.38% ======================================= Files 37 37 Lines 4158 4158 ======================================= Hits 3467 3467 Misses 691 691 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.