Closed rluvaton closed 7 months ago
Patch and project coverage have no change.
Comparison is base (
6d68c99
) 83.03% compared to head (e8a3095
) 83.03%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is it reasonable to add a test for this change? (Non-blocking but of course I'd prefer a test to not having test if it's not too onerous.)
I totally with you on adding test but there where no test to begin with
I will try to add one...
Please do not hard code
'upstream'
, and take the name of the upstream from the config instead.
@aduh95 fixed
Fixes #731
this aligns with steps 1-3 in
doc/contributing/backporting-to-release-lines.md
- How to submit a backport pull requesthttps://github.com/nodejs/node/blob/c2cd74453e7d2794ad81cab63e68371e08bad04f/doc/contributing/backporting-to-release-lines.md?plain=1#L48-L62