search

nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
234 stars 106 forks source link

chore: remove EoL Node.js 16 from test matrix #733

Closed rluvaton closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03% :warning:

Comparison is base (6d68c99) 83.03% compared to head (84fe43f) 83.00%. Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #733 +/- ## ========================================== - Coverage 83.03% 83.00% -0.03% ========================================== Files 37 37 Lines 4178 4184 +6 ========================================== + Hits 3469 3473 +4 - Misses 709 711 +2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/nodejs/node-core-utils/pull/733/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Trott commented 7 months ago

Can you please update the "engines" field in package.json as well?

Trott commented 7 months ago

Totally not necessary for this PR but optional here or as a future enhancement: If we use the pkgjs prepare-node-test-matrix GitHub Action instead of hardcoding the Node.js version numbers, it will look at the "engines" property in package.json and only test the LTS versions at or above that level along with the current version. See https://github.com/pkgjs/action/tree/main for more information. (pkgjs is the tooling org managed in a very hands-off way by the TSC for Node.js.)

rluvaton commented 7 months ago

@Trott moved to prepare-node-test-matrix 😄