search

nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
234 stars 106 forks source link

add --skip-more-than to ncu-ci and show console URL for "Appeared on" #741

Closed joyeecheung closed 7 months ago

joyeecheung commented 7 months ago

feat: add --skip-more-than to ncu-ci to skip real test failures

fix: link to failure console for "Appeared on" in ncu-ci

Because it's more useful than the computer URL. Also use CI URL for PRs instead of the PR URLs themselves.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f30cdba) 83.38% compared to head (575d5ce) 82.95%. Report is 20 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #741 +/- ## ========================================== - Coverage 83.38% 82.95% -0.43% ========================================== Files 37 37 Lines 4158 4190 +32 ========================================== + Hits 3467 3476 +9 - Misses 691 714 +23 ``` | [Files](https://app.codecov.io/gh/nodejs/node-core-utils/pull/741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs) | Coverage Δ | | |---|---|---| | [lib/ci/build-types/pr\_build.js](https://app.codecov.io/gh/nodejs/node-core-utils/pull/741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2NpL2J1aWxkLXR5cGVzL3ByX2J1aWxkLmpz) | `92.07% <100.00%> (ø)` | | | [lib/links.js](https://app.codecov.io/gh/nodejs/node-core-utils/pull/741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2xpbmtzLmpz) | `91.86% <50.00%> (ø)` | | | [lib/ci/build-types/commit\_build.js](https://app.codecov.io/gh/nodejs/node-core-utils/pull/741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs#diff-bGliL2NpL2J1aWxkLXR5cGVzL2NvbW1pdF9idWlsZC5qcw==) | `77.96% <57.14%> (-1.50%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/nodejs/node-core-utils/pull/741/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nodejs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.