search

nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
228 stars 105 forks source link

CI fails on Node.js 21 #752

Closed targos closed 4 months ago

targos commented 5 months ago

See https://github.com/nodejs/node-core-utils/actions/runs/6847526575/job/18615958948?pr=751

targos commented 5 months ago

@nodejs/test_runner Is there a way to execute the test runner with arguments that work in all supported Node.js versions?

targos commented 5 months ago

@MoLow Do you know of a solution?

MoLow commented 5 months ago

not a good one. I would try changing the command based on the node version, we can also run node --test $(find . -name 'test/unit/**.js' | tr '\n' ' ') which will be compatible for all versions

targos commented 5 months ago

This is unfortunate. Isn't it a big issue for adoption of the test runner by projects that want to support all release lines?

MoLow commented 5 months ago

It probably is, we should have probably thought about that - although this change was a semver major change, and was necessary since it made it possibe to run typescript tests or tests other then the default pattern

aduh95 commented 5 months ago

I guess we could backport it behind a --experimental-glob-in-test-runner flag or something like that

ljharb commented 5 months ago

Major changes for a test runner built into the platform will always cause this problem; the only solution is to never have them, or, not have a test runner that’s built in.