search

nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
228 stars 105 forks source link

fix(v8): clone V8 repository when it's not present #756

Closed aduh95 closed 5 months ago

aduh95 commented 5 months ago

Previously, when the V8 repository was not present, it would emit an 'error' event instead of rejecting the promise, causing the process to crash instead of running the fallback.

Fixes: https://github.com/nodejs/node-core-utils/issues/743

codecov[bot] commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a9e0144) 82.95% compared to head (067ab06) 82.93%.

Files Patch % Lines
lib/run.js 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #756 +/- ## ========================================== - Coverage 82.95% 82.93% -0.02% ========================================== Files 37 37 Lines 4190 4191 +1 ========================================== Hits 3476 3476 - Misses 714 715 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.