nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
228 stars 105 forks source link

fix(node): do not trust committed date #758

Closed aduh95 closed 4 months ago

aduh95 commented 5 months ago

The date of a commit is provided by the user, and we should not trust it blindly. Instead, we can check when was the last push event to the PR base branch.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dbd8c65) 82.93% compared to head (2968f30) 82.97%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #758 +/- ## ========================================== + Coverage 82.93% 82.97% +0.03% ========================================== Files 37 37 Lines 4191 4200 +9 ========================================== + Hits 3476 3485 +9 Misses 715 715 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.