nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
228 stars 105 forks source link

Feat: validate gpg releasers signatures #760

Open UlisesGascon opened 4 months ago

UlisesGascon commented 4 months ago

Notes

This is currently under a draft version. They main objetive is to collect early feedback before creating the final PR (proper linting, tests, etc...)

This is my first time doing changes on NCU so I might be using wrongly the API or breaking any expected convention, please let me know 👍

What is this feature about?

While working on https://github.com/nodejs/Release/pull/966, @RafaelGSS suggested to extend the NCU to review the signatures.

This PR introduce a new command ncu-team check-gpg. This command will check the current releasers team members and the available information in the README.md and make some checks on the status of the individuals keys and if the keys/releasers are properly listed on the README.md

Currently checks included

Potential additional checks

Current output

Screenshot 2023-12-04 at 17 44 03