search

nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
228 stars 105 forks source link

fix(ci): use shell expansion to run test files #761

Closed aduh95 closed 4 months ago

aduh95 commented 4 months ago

Fixes: https://github.com/nodejs/node-core-utils/issues/752

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7df1d0c) 82.93% compared to head (6b1fe14) 82.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #761 +/- ## ======================================= Coverage 82.93% 82.93% ======================================= Files 37 37 Lines 4191 4191 ======================================= Hits 3476 3476 Misses 715 715 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aduh95 commented 4 months ago

Blocked on https://github.com/rvagg/ghauth/pull/31

aduh95 commented 4 months ago

Yeah not sure why the CI doesn't run on Windows. I think it should work on Windows as long as you're using Node.js 21+ to run the tests.