nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
228 stars 105 forks source link

feat: security post release blogpost #785

Open marco-ippolito opened 1 month ago

marco-ippolito commented 1 month ago

Pos release blogpost cc @RafaelGSS

Fixes: https://github.com/nodejs-private/security-release/issues/27

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.97%. Comparing base (8a04848) to head (0db4650). Report is 3 commits behind head on main.

:exclamation: Current head 0db4650 differs from pull request most recent head 585007a. Consider uploading reports for the commit 585007a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #785 +/- ## ======================================= Coverage 82.97% 82.97% ======================================= Files 37 37 Lines 4200 4200 ======================================= Hits 3485 3485 Misses 715 715 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marco-ippolito commented 1 month ago

once this lands: https://github.com/nodejs/node-core-utils/pull/788 we can automatically pull in dependencies and openssl updates

marco-ippolito commented 1 month ago

blocked by: https://github.com/nodejs/node-core-utils/pull/788 I will have to update the workflow once this lands

richardlau commented 1 week ago

This is a minor inconsistency note, but we used to add (Update <date>) to the blog posts as they were updated, e.g.

but didn't in the two most recent releases:

marco-ippolito commented 1 week ago

Update

I thought that's for when the security release is delayed

marco-ippolito commented 1 week ago

Check lint please

lint seems to pass locally what command are you running?

richardlau commented 1 week ago

Update

I thought that's for when the security release is delayed

I thought we also did that to denote the update from the pre-announcement.

RafaelGSS commented 1 week ago

Check lint please

lint seems to pass locally what command are you running?

IIRC we are using * instead of - for listing vulnerabilities (or the inverse:sweat_smile:) and the linter of nodejs.org complains. Try to create a real example with vulnerabilities and run lint