search

nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
228 stars 105 forks source link

feat: prompt dependency updates url in vulnerabilities.json creation #788

Closed marco-ippolito closed 2 weeks ago

marco-ippolito commented 1 month ago

Fixes: https://github.com/nodejs-private/security-release/issues/9 Also we prompt for the release date for the issue, it makes sense to add it to the vulnerabilities.json, if it doesnt change you dont have to do anything, if it changes you would have to update it either way.

I think I should also create an automation to add/remove them.

cc @RafaelGSS

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.97%. Comparing base (8a04848) to head (95b8455).

:exclamation: Current head 95b8455 differs from pull request most recent head 1ad27f8. Consider uploading reports for the commit 1ad27f8 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #788 +/- ## ======================================= Coverage 82.97% 82.97% ======================================= Files 37 37 Lines 4200 4200 ======================================= Hits 3485 3485 Misses 715 715 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marco-ippolito commented 2 weeks ago

@RafaelGSS this is ready to land