search

nodejs / node-core-utils

CLI tools for Node.js Core collaborators
https://nodejs.github.io/node-core-utils/
MIT License
228 stars 105 forks source link

feat: add releaseDate to json #796

Closed marco-ippolito closed 1 week ago

marco-ippolito commented 2 weeks ago

Fixes: https://github.com/nodejs-private/security-release/issues/23

@RafaelGSS

marco-ippolito commented 2 weeks ago

actually, we need to check if a valid date is given, if not it should leave it empty. For instance, TBD.

if invalid date is given it will throw right now

RafaelGSS commented 2 weeks ago

actually, we need to check if a valid date is given, if not it should leave it empty. For instance, TBD.

if invalid date is given it will throw right now

But, what if we don't have a target date? I would like to pass TBD

marco-ippolito commented 1 week ago

ok so I'll validate only if different from 'TBD'