feat(ncu-ci)!: require `--certify-safe` flag

nodejs / node-core-utils

CLI tools for Node.js Core collaborators

https://nodejs.github.io/node-core-utils/

MIT License

234 stars 106 forks source link

feat(ncu-ci)!: require `--certify-safe` flag #798

Closed aduh95 closed 3 weeks ago

aduh95 commented 3 weeks ago

Or ensure the PR has received at least one approving review since last time it was pushed.

joyeecheung commented 2 weeks ago

This is currently a bit too restrictive - it should add an exceptions to collaborators otherwise even a collaborator cannot use the label to run the CI wihout an approving review (or after they've pushed a new commit), see https://github.com/nodejs/node/pull/52692

ovflowd commented 1 week ago

@aduh95 do you intend to make a patch based on what @joyeecheung mentioned? 👀