Closed bmeck closed 8 years ago
lgtm sans inline nits, I also don't like the heavy inconsistency in line lengths (personally I'd prefer paragraphs on a single line but it's consistency I care about more) but not enough to hold this up, just a note for future process improvement perhaps.
@rvagg https://tc39.github.io/ecma262/ doesn't always highlight names, was trying to match them, though saw no direct style guide, will amend though
@rvagg fixed, though some lines still exceed 80, (code and href)
You can argue line-length with @trevnorris and @bnoordhuis, they are the ones who use XGA CRT monitors which have limitations, I'm easy as long as it looks consistent.
lgtm, happy to see this landed after the usual delay, would appreciate additional review of course.
@bmeck Minor comment that I can easily fix before merging.
@rvagg My line limit arguments only apply to code. Just find it convenient for review purposes with text. :)
It's OK @trevnorris, you don't need to explain
@trevnorris fixed
LGTM
Thanks much! Squashed and landed in 2272a8138a.