nodejs / node-eps

Node.js Enhancement Proposals for discussion on future API additions/changes to Node core
443 stars 66 forks source link

uv_link_t: initial #32

Closed indutny closed 7 years ago

indutny commented 8 years ago

cc @nodejs/ctc @trevnorris @nodejs/collaborators @saghul

eljefedelrodeodeljefe commented 8 years ago

As far as I can see, this would tremendously help native addons writers also, since StreamBase is indeed very bulky. Decreasing boilerplate one has to implement to hook in C programs into js-streams is definitely worth an addition like this. Awesome work, btw.

Qard commented 8 years ago

Indeed, this looks great! The more we can leverage libuv to do the heavy lifting generically, the better. :smile_cat:

jasnell commented 8 years ago

oooo... yes please. this definitely looks promising.

indutny commented 8 years ago

Added note about observability and data events. This is very important too.

trevnorris commented 8 years ago

Overall I dig it. Would like @bnoordhuis' opinion.

indutny commented 8 years ago

@trevnorris thank you!

indutny commented 8 years ago

Thank you for review @trevnorris !

bnoordhuis commented 8 years ago

The document should provide some detail on how uv_link_t is supposed to work. It currently just, ah, links to https://github.com/indutny/uv_link_t without further explanation.

indutny commented 8 years ago

@bnoordhuis I can copy-paste "How?" from https://github.com/indutny/uv_link_t#how , will it suffice?

bnoordhuis commented 8 years ago

Yes, but it should probably also say a few words about how it's going to be hooked up in node.js.

indutny commented 8 years ago

@bnoordhuis sorry for delay, pushed update.

indutny commented 7 years ago

Should I land this? Its been awhile since the last review, and I believe that there is a general agreement about this feature.

Trott commented 7 years ago

Should I land this?

Since it says status is DRAFT, and the README says all EPs regardless of status should be landed...I'd say yes. Landing it as DRAFT status especially should be uncontroversial.

indutny commented 7 years ago

Alright, landing!

indutny commented 7 years ago

Landed in 2c45bf0, thank you!