search

nodejs / node-eps

Node.js Enhancement Proposals for discussion on future API additions/changes to Node core
442 stars 66 forks source link

Editorial fixes / suggestions for ES6 Module Interoperability #37

Closed jmm closed 6 years ago

jmm commented 8 years ago

Separate commits to make it easier to consider the changes individually.

56faad9f182df68e8c25ee86196100e7b414e155 Some of the changes are subjective style suggestions, but I think the named export language here could be confusing in terms of ability to reassign the value of a binding inside the module that exports it:

Attempting to reassign any named export will not work

Properties of namespace objects are live bindings, right?

f753479ec1856e347b7ff9dbcbe110ef37b9f139 Style nit. The formatting ModuleNamespace or ModuleNamespaceObject doesn't seem to appear in the spec. It seems to always be Module Namespace [Exotic] Object (though sometimes it's lowercase and sometimes title case).

If you don't like the style changes, ¯_(ツ)_/¯, but hopefully you find the other stuff worthwhile.

trevnorris commented 8 years ago

cc @bmeck

bmeck commented 8 years ago

after tc39 meeting there will be rather drastic changes, will review after a meeting on Wednesday about things

Trott commented 6 years ago

Thanks for the pull request! Modules work is now happening elsewhere (in the nodejs/modules and nodejs/node repositories) and this repository seems likely to be archived soon. I'm going to close this, but if you want these changes to land, by all means, comment and rebase.