nodejs / node-eps

Node.js Enhancement Proposals for discussion on future API additions/changes to Node core
443 stars 66 forks source link

Fix typo in es6 modules proposal #41

Closed ethanresnick closed 7 years ago

ethanresnick commented 7 years ago

Hi,

I may be understanding the proposal wrong, in which case please close this PR.

If I'm understanding it correctly, though, I'd expect import * as bar from './cjs.js'; to be a ModuleNamespaceObject rather than the module.exports function value, so name would be undefined. Right?

ethanresnick commented 7 years ago

Whoops, just saw #39, so I guess this is irrelevant.