Open cinderblock opened 1 month ago
This was first brought up in a review. A couple people mentioned this. No action was taken.
https://github.com/nodejs/node-gyp/pull/1573/files/020e2bdb6836b57462cccac6083a67f074019658#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
Why is package-lock.json ignored? https://github.com/nodejs/node-gyp/blob/main/.gitignore#L7
package-lock.json
The general consensus seems to bee that it should be committed. If there is a reason it shouldn't, it should probably be listed alongside the ignore (as a comment).
This was first brought up in a review. A couple people mentioned this. No action was taken.
https://github.com/nodejs/node-gyp/pull/1573/files/020e2bdb6836b57462cccac6083a67f074019658#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947
Why is
package-lock.jsonignored? https://github.com/nodejs/node-gyp/blob/main/.gitignore#L7The general consensus seems to bee that it should be committed. If there is a reason it shouldn't, it should probably be listed alongside the ignore (as a comment).