search

nodejs / node-report

Delivers a human-readable diagnostic summary, written to file.
https://www.npmjs.com/package/node-report
Other
326 stars 45 forks source link

Fix build on Windows with libuv 1.22 and later #118

Closed richardlau closed 5 years ago

richardlau commented 5 years ago

On Windows in libuv 1.22 and later the due member was renamed to timeout for consistency with the other platforms.

Fixes: https://github.com/nodejs/node-report/issues/113

richardlau commented 5 years ago

CI against Node.js 10: https://ci.nodejs.org/job/nodereport-continuous-integration/258/ ✔️

richardlau commented 5 years ago

Needs a review.

cc @nodejs/diagnostics @nodejs/platform-windows @targos

richardlau commented 5 years ago

Landed in https://github.com/nodejs/node-report/commit/a696eb010a868a3f4ae9683c5f90dfe6b658f6a3.