search

nodejs / node-report

Delivers a human-readable diagnostic summary, written to file.
https://www.npmjs.com/package/node-report
Other
326 stars 45 forks source link

Restore uppercase C++ method names #127

Closed richardlau closed 5 years ago

richardlau commented 5 years ago

fabac78 changed the exported C++ method names to start with a lower case character to match the name exported to JavaScript land. This turns out to be unnecessary if Nan::SetMethod() is used instead of NAN_EXPORT(). Restore the original casing of the C++ methods to be consistent with the non-exported C++ methods.

Refs: https://github.com/nodejs/node-report/pull/125#issuecomment-478118312

cc @sam-github

richardlau commented 5 years ago

CI Node.js 6: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/308/ (:heavy_check_mark:) CI Node.js 8: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/309/ (:heavy_check_mark:) CI Node.js 10: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/310/ (:heavy_check_mark:) CI Node.js 11: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/311/ (:heavy_check_mark:) CI Node.js 12: https://ci.nodejs.org/view/post-mortem/job/nodereport-continuous-integration/312/ (:heavy_check_mark:)