Closed richardlau closed 7 years ago
Good catch!
I wonder if reporting the version nodereport was built against, distinct from the run version, would be useful?
Perhaps. The report doesn't actually include the version of nodereport itself, so maybe something like nodereport v1.0.6 built against Node.js v6.9.1
?
Sounds good to me.
Reports currently contain in the
NodeReport
section:If I compile nodereport with one version of Node.js (e.g. v6.9.1) and then run on another version (e.g. v6.7.0) the report incorrectly reports
v6.9.1
and notv6.7.0
(note that it correctly reportsv8: 5.1.281.83
):Looks like compile time constants are being used in
src/nodereport.cc
:zlib
andares
versions are also at risk of being incorrectly reported.Pull request incoming.