seems to not account for when a review has been dismissed

nodejs / node-review

A browser extension that generates the metadata required for landing a Node.js Pull Request

15 stars 16 forks source link

seems to not account for when a review has been dismissed #14

Closed sam-github closed 5 years ago

sam-github commented 7 years ago

example: https://github.com/nodejs/node/pull/10747

refack commented 7 years ago

I just encountered that and patched it yesterday 😄. Just opened PR https://github.com/evanlucas/node-review/pull/15

joyeecheung commented 6 years ago

Looks like it still doesn't handle https://github.com/nodejs/node/pull/14782 when someone dissmised their own reviews

joyeecheung commented 6 years ago

Funny enough, it also tries to delete my review (not that I have approved or rejected at that point) from the map when I added a reference with a title containing "dismissed" lol

sam-github commented 5 years ago

Looks like @joyeecheung fixed this in #16 (but it can be reopened if that is not the case).