nodejs / node-v0.x-archive

Moved to https://github.com/nodejs/node
34.41k stars 7.31k forks source link

Unit test failure (Windows): simple/test-debugger-repl #5070

Closed sblom closed 10 years ago

sblom commented 11 years ago
=== release test-debugger-repl ===
Path: simple/test-debugger-repl
connecting... ok
./node debug --port=13683 E:\src\node\master\test\fixtures/breakpoints.js
UncaughtException { name: 'AssertionError',
  message: '\bconnecting... ok != /listening on port \\d+/',
  actual: false,
  expected: true,
  operator: '==' } AssertionError:connecting... ok != /listening on port \d+/
    at ChildProcess.callback (E:\src\node\master\test\simple\test-debugger-repl.js:56:10)
    at ChildProcess.EventEmitter.emit (events.js:95:17)
    at E:\src\node\master\test\simple\test-debugger-repl.js:43:11
    at Array.forEach (native)
    at Socket.expected (E:\src\node\master\test\simple\test-debugger-repl.js:42:8)
    at Socket.EventEmitter.emit (events.js:95:17)
    at Socket.<anonymous> (_stream_readable.js:699:14)
    at Socket.EventEmitter.emit (events.js:92:17)
    at emitReadable_ (_stream_readable.js:382:10)
    at emitReadable (_stream_readable.js:377:5)
AssertionError:connecting... ok != /listening on port \d+/
process exit 1
Command: e:\src\node\master\Release\node.exe E:\src\node\master\test\simple\test-debugger-repl.js
sblom commented 11 years ago

This looks like a connect-time race condition or something like it. Instead of getting

  /listening on port \d+/,
  /connecting... ok/,
  /break in .*:1/,

as the test expects, I just get

< debugger listening on port 12345
debug>  ok

But the state of the debugger is such that it has hit the first breakpoint in the test script.

ryancole commented 10 years ago

This test file has been moved to the debugger directory. It's no longer in simple. Also, on Windows 8.1 64-bit, with node v0.11.13-pre, the tests in this file seem to pass. Perhaps this issue can be closed?

tjfontaine commented 10 years ago

The tests are racey, it works more reliably on windows since we've solved some of the stderr issues, closing indeed