Closed gengjiawen closed 4 years ago
After use git node v8 major with this repo, build on linux failed with. Not sure I miss something.
Well that's warning that whatever version of V8 is being updated to has now deprecated an API we're currently using in core. Which is the whole point of error-on-warn
-- it makes it obvious when situations like this occur. It's indicative of an issue coming down the line, as deprecated V8 APIs tend to eventually be removed.
Looks like indirect use, I searched the src folder, not finding AddMicrotasksCompletedCallback
or RemoveMicrotasksCompletedCallback
.
Did you re-apply the commits from the canary-base
branch on top of the update?
This error should be fixed by https://github.com/nodejs/node/commit/df80a5dde650e317f32bb5af436867bd2ed691c1
Did you re-apply the commits from the
canary-base
branch on top of the update? This error should be fixed by nodejs/node@df80a5d
Thanks, this should be the reason.
After use git node v8 major with this repo, build on linux failed with. Not sure I miss something.
cc @richardlau
https://github.com/gengjiawen/node-v8/runs/864971031?check_suite_focus=true