nodejs / node-v8

Experimental Node.js mirror on V8 lkgr :sparkles::turtle::rocket::sparkles:
410 stars 68 forks source link

Restructure repository branches #170

Open mmarchini opened 3 years ago

mmarchini commented 3 years ago
mmarchini commented 3 years ago

We can start by creating the main branch with an empty README, and then slowly we can work on the other changes there (via PRs) and then once we're confident this new system is working and is better than the current state we can switch it.

targos commented 3 years ago

Drop canary-base branch on nodejs/node and use patch files on this repository instead.

I'm not opposed to it, but having a branch to manage the canary patches helps me a lot because I can easily use git cherry-pick and git rebase. We need to make sure patch files don't slow down the regular processes of

mmarchini commented 3 years ago

Definitely. I'm proposing these changes because I do believe they will make the overall process faster (or at least simpler), but we'll definitely need some experimentation in order to get it right.

Edit: for major V8 upgrades, we could even have an Action that opens the PR and updates it every time we update the patches list (edit 2: and dropping canary-base is not a requirement for that, so I'll go ahead and add it to the list :) )

mmarchini commented 3 years ago

Besides dropping the canary-base branch, what are your thoughts on the other changes?

targos commented 3 years ago

Other changes SGTM