search

nodejs / node-v8

Experimental Node.js mirror on V8 lkgr :sparkles::turtle::rocket::sparkles:
410 stars 69 forks source link

Review state of canary in CI #285

Open targos opened 3 months ago

targos commented 3 months ago

Previous thread: https://github.com/nodejs/node-v8/issues/249

targos commented 3 months ago

Commit: https://github.com/nodejs/node-v8/commit/30329d06235a9f9733b1d4da479b403462d1b326 CI: https://ci.nodejs.org/job/node-test-commit/71329/ V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/6020/

targos commented 3 months ago

V8 CI is broken: https://ci.nodejs.org/job/node-test-commit-v8-linux/6020/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console

13:29:56 + PATH=/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools:/home/iojs/build/workspace/node-test-commit-v8-linux/depot_tools:/home/iojs/venv/bin:/home/iojs/nghttp2/src:/home/iojs/wrk:/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin tools/dev/v8gen.py x64.release --no-goma
13:29:56 usage: v8gen.py [-h] {gen,list} ...
13:29:56 v8gen.py: error: unrecognized arguments: --no-goma

https://github.com/v8/v8/commit/6c5a6c03dd6f557fcdf550ae3a2c66ed66d805ce

I opened a PR removing the argument from make-v8.sh.