nodejs / node-v8

Experimental Node.js mirror on V8 lkgr :sparkles::turtle::rocket::sparkles:
415 stars 70 forks source link

Build error in canary update #292

Open targos opened 21 hours ago

targos commented 21 hours ago

https://github.com/nodejs/node-v8/actions/runs/11156715043

In file included from ../deps/v8/src/maglev/maglev-basic-block.h:13,
                 from ../deps/v8/src/compiler/turboshaft/maglev-graph-building-phase.cc:42:
../deps/v8/src/maglev/maglev-interpreter-frame-state.h:508:39: error: ‘LoopEffects’ has not been declared
  508 |       const KnownNodeAspects&, bool&, LoopEffects*&, Zone*&);
      |                                       ^~~~~~~~~~~
../deps/v8/src/maglev/maglev-interpreter-frame-state.h:506:28: error: template-id ‘New<v8::internal::maglev::KnownNodeAspects, const v8::internal::maglev::KnownNodeAspects&, bool&, v8::internal::maglev::LoopEffects*&, v8::internal::Zone*&>’ for ‘v8::internal::maglev::KnownNodeAspects* v8::internal::Zone::New<v8::internal::maglev::KnownNodeAspects, const v8::internal::maglev::KnownNodeAspects&, bool&, v8::internal::maglev::LoopEffects*&, v8::internal::Zone*&>(const v8::internal::maglev::KnownNodeAspects&, bool&, int*&, v8::internal::Zone*&)’ does not match any template declaration
  506 |   friend KnownNodeAspects* Zone::New<KnownNodeAspects, const KnownNodeAspects&,
      |                            ^~~~
In file included from ../deps/v8/src/zone/zone-chunk-list.h:10,
                 from ../deps/v8/src/codegen/maglev-safepoint-table.h:14,
                 from ../deps/v8/src/objects/code.h:8,
                 from ../deps/v8/src/codegen/reloc-info.h:11,
                 from ../deps/v8/src/codegen/assembler.h:53,
                 from ../deps/v8/src/compiler/turboshaft/phase.h:13,
                 from ../deps/v8/src/compiler/turboshaft/maglev-graph-building-phase.h:10,
                 from ../deps/v8/src/compiler/turboshaft/maglev-graph-building-phase.cc:5:
../deps/v8/src/zone/zone.h:112:6: note: candidate is: ‘template<class T, class ... Args> T* v8::internal::Zone::New(Args&& ...)’
  112 |   T* New(Args&&... args) {
      |      ^~~
  CXX(target) /home/runner/work/node-v8/node-v8/node-v8/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/turboshaft/optimize-phase.o
targos commented 21 hours ago

This workflow still runs on Ubuntu 22.04 with GCC 11. I'll update it.

targos commented 21 hours ago

https://github.com/nodejs/node-v8/pull/293