feature request: EventEmitter#off() alias for EventEmitter#removeListener()

nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨

https://nodejs.org

Other

106.6k stars 29.07k forks source link

feature request: EventEmitter#off() alias for EventEmitter#removeListener() #1064

Closed jokeyrhyme closed 9 years ago

jokeyrhyme commented 9 years ago

makes the API more symmetrical: we already have an EventEmitter#on() alias for EventEmitter#addListener()
Wolfy87/EventEmitter has #off()
Backbone.js has #off()
this seems to be a fairly common pattern of convenience elsewhere in the ecosystem

Is this the sort of thing you'd welcome a PR for? Or is this not something you're interested having in core?

jokeyrhyme commented 9 years ago

Cross-posted with Node.js: https://github.com/joyent/node/issues/9332

tellnes commented 9 years ago

Here is some references. There is probably a few more that I've forgotten. https://github.com/iojs/io.js/pull/540 https://github.com/joyent/node/pull/3338 https://github.com/joyent/node/issues/5352

Fishrock123 commented 9 years ago

From #540

And off is weird. event listeners aren't light switches. "on" has a number of meanings, "off" is the opposite of only some of those meanings. "under" is also an antonym of "on"... but neither "under" nor "off" are antonyms of the meaning of "on" used by EE.

jokeyrhyme commented 9 years ago

Sorry about the duplicate. I swear I did search first. /shrug Arguments against this make sense. :)