nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
106.55k stars 29.04k forks source link

test: test-crypto-dh-leak flaky #14424

Closed refack closed 7 years ago

refack commented 7 years ago

A new test introduced in https://github.com/nodejs/node/pull/14122. Flaky probably because the allowed wiggle room is too tight. https://ci.nodejs.org/job/node-test-commit-arm/11062/nodes=ubuntu1604-arm64/

not ok 277 parallel/test-crypto-dh-leak
  ---
  duration_ms: 2.497
  severity: fail
  stack: |-
    assert.js:43
      throw new errors.AssertionError({
      ^

    AssertionError [ERR_ASSERTION]: false == true
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/nodes/ubuntu1604-arm64/test/parallel/test-crypto-dh-leak.js:26:1)
        at Module._compile (module.js:569:30)
        at Object.Module._extensions..js (module.js:580:10)
        at Module.load (module.js:503:32)
        at tryModuleLoad (module.js:466:12)
        at Function.Module._load (module.js:458:3)
        at Function.Module.runMain (module.js:605:10)
        at startup (bootstrap_node.js:158:16)
        at bootstrap_node.js:575:3
  ...

Code:

// RSS should stay the same, ceteris paribus, but allow for
// some slop because V8 mallocs memory during execution.
assert(after - before < 5 << 20);

/cc @bnoordhuis

Trott commented 7 years ago

Saw it somewhere else. Hope this one isn't going to pop up too frequently....

https://ci.nodejs.org/job/node-test-commit-arm/11038/nodes=ubuntu1604-arm64/console

not ok 264 parallel/test-crypto-dh-leak
  ---
  duration_ms: 1.962
  severity: fail
  stack: |-
    assert.js:43
      throw new errors.AssertionError({
      ^

    AssertionError [ERR_ASSERTION]: false == true
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-arm/nodes/ubuntu1604-arm64/test/parallel/test-crypto-dh-leak.js:26:1)
        at Module._compile (module.js:569:30)
        at Object.Module._extensions..js (module.js:580:10)
        at Module.load (module.js:503:32)
        at tryModuleLoad (module.js:466:12)
        at Function.Module._load (module.js:458:3)
        at Function.Module.runMain (module.js:605:10)
        at startup (bootstrap_node.js:158:16)
        at bootstrap_node.js:575:3
  ...
bnoordhuis commented 7 years ago

https://github.com/nodejs/node/pull/14451

bnoordhuis commented 7 years ago

Fixed by 1fa67c7.