nodejs / node

Node.js JavaScript runtime ✨🐢🚀✨
https://nodejs.org
Other
107.67k stars 29.63k forks source link

Removing the bench-* targets in makefile? #17053

Closed joyeecheung closed 6 years ago

joyeecheung commented 6 years ago

Hi all, just wondering is there anyone actually using the bench- targets in the Makefile? This is not used by the benchmark CI, and basically those just call `./node benchmark/run.js which is not really that hard to remember (and this does not even allow you to set the arguments at all. Besides, these days we tend to usebenchmark/compare.jsinstead). Thebench-allandbench` target somehow only run a subset of the benchmarks and they are not covering all the categories that we have anyway. Based on this I think those are not maintained and not really used anymore so I am just wondering maybe we can remove those altogether.

Refs: https://github.com/nodejs/node/pull/16934

joyeecheung commented 6 years ago

cc @nodejs/build @nodejs/performance @nodejs/benchmarking

gibfahn commented 6 years ago

SGTM

gareth-ellis commented 6 years ago

SGTM too,

rvagg commented 6 years ago

not aware of anyone else using it, so sgtm and +1 for decluttering Makefile in general